fix($http): do not add trailing question #6342
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I've recommit changes with another my email, which already signed. Check this again, please. |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
| it('should not add question mark when params is empty', function() { | ||
| $httpBackend.expect('GET', '/url').respond(''); | ||
| $http({url: '/url', params: {}, method: 'GET'}); | ||
| }) |
There was a problem hiding this comment.
semicolon missing. we'll start automatically validating this in the future. just fyi
|
this is a very nice fix. thank you! |
Now if you pass empty object into params you will get url with unnecessary question mark.
It may cause some issues, like this stackoverflow question.
Moreover it makes unit test less readable, because that need to add redundant question to end of some
$httpBackendexpectations.