This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
refactor($cacheFactory): cache inefficient when no capacity #6226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip maintaining the linked list when cache capacity not specified closes angular#6193
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| @@ -6,9 +6,9 @@ | |||
| * | |||
| * @description | |||
| * Factory that constructs cache objects and gives access to them. | |||
| * | |||
There was a problem hiding this comment.
what's with the whitespace changes? I'm not sure they're bad changes, but they might not belong in the diff
There was a problem hiding this comment.
Yes, you're right. It was my fault. The editor settings of my WebStorm were like this: "strip trailing spaces on save: all". I have reverted the whitespace changes.
|
@caitp Whitespace changes reverted. I had bad IDE settings. |
|
thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser: Chrome
Component: misc core
Regression: yes
skip maintaining the linked list when cache capacity not specified
closes #6193