fix($q): make $q.reject support finally and catch
#6076
Conversation
Add support for the functions `finally` and `catch` to the promise returned by `$q.reject` Closes angular#6048
| return result.promise; | ||
| }; | ||
|
|
||
| var _reject = function(reason) { |
There was a problem hiding this comment.
The one thing I don't like about this, is the naming of this function... I think it's a bit confusing, and would be better renamed to something like rejectImpl or something. I'm not sure everyone else would share this same opinion, though.
There was a problem hiding this comment.
I agree. we should call it something like createInternalRejectedPromise or something of that sort. we already have 3 other reject methods/fields in this file so 4th is making it even worse especially since it's an internal-only factory function.
|
otherwise LGTM! thanks @lgalfaso ! |
|
@IgorMinar mind if I just amend this real quick with that change and merge it? Would be good to ship this ... haven't heard from anyone about problems with this, but I'll revert if needed. Merging |
Add support for the functions
finallyandcatchto the promise returned by$q.rejectCloses #6048