fix(shallowCopy) logic error where '$foo' would be ignored

[basarat]

Introduced in this commit : cb29632

[caitp]

Hey, so going back to at least 1.2.3, we weren't ignoring properties with a single dollar-sign prefix (and, there are some potential uses for properties with these names, like writing queries to be fed directly into mongodb, not that I recommend anyone do that).

This would be a breaking change, although I'm not totally sure about the impact.

[basarat]

so going back to at least 1.2.3, we weren't ignoring properties with a single dollar-sign prefix

shallowCopy should only ignore $$anything not $anything. Before 1.2.3 it was $$anything only. Then the change was made to new code for performance which changed it to ignore $anything by mistake. If we only wanted $anything then key.charAt(0) != '$' would have been sufficient which is not the original code.

[caitp]

Ah, I see what you're saying, just tested on a fiddle. Okay, so this is a proper fix and not a breaking change.

What I'd like to see before LGTM-ing this is some tests added so that we can guard against breaking this inadvertently in the future.

@IgorMinar I'd like to get this into 1.2.11 once tests are added, does that look alright to you?

[petebacondarwin]

LGTM. We should have unit tests to cover this

[caitp]

I'm not sure if they've already begun cutting the release or not... this might not be able to make it in this week :(

[caitp]

I just realized that this is actually a dupe of #5666. Hm. First one to add tests gets merged? :D

[atomrc]

@caitp Just updated my pull request with tests for shallowCopy in Angular.js and shallowCopyAndClear in ngResource

#5666

Am I to be merged ;) ?

[caitp]

@thomasbelin4 yes thank you, merged in d2e4e49

[atomrc]

Hell Yeah :) Thanks @caitp