feat(ngMock.$httpBackend): added support for function as URL matcher #4580
Conversation
It's now possible to pass a function to match the URL in $httpBackend mocked expectations. This gives a more sophisticate control over the URL matching without requiring complex RegExp mantainance or the workaround of creating an object with a `test` function in order to mimic RegExp interface. Docs were also updated. This approach was suggested in [this thread](https://groups.google.com/d/msg/angular/3QsCUEvvxlM/Q4C4ZIqNIuEJ)
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Just to let you know that most of the changes to ngMock file relate to the Docs, the only line that really matters is 1553. Also I've already signed the CLA for past PRs. |
|
Nics |
|
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
You're right. The previous PR was from a different email. Just signed. PS2: I'm not :) |
|
I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let me know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I've signed the first time you posted this message. Are you still unable to find my CLA? I signed again, just in case. |
|
@caiotoon the email addresses don't match. can you change your commit or sign the cla with the same email as the one in the current commit? |
|
Sorry, maybe I'm missing something. I double check the commit e-mail and It seems to be the same one at my GitHub public profile: opensource at my-username.com, right? (got from I've signed using the same e-mail. Do you think it could take some days to the CLA signature to be processed? Is there anything else I could try? |
|
Hi @IgorMinar. Any news on this one? Do you think it would worth creating a new PR, trying to sign the CLA again? Anything I could help with? |
|
@IgorMinar I've subimitted the application by email a couple of days ago. Would you please check if you can verify it again? |
|
the problem is that you signed CLA with |
|
Same problem as I had in the other thread. I've signed with both mentioned e-mails, as explained here. Just did it once more for this e-mail. I'm sorry for the inconvenient, will commit with the former e-mail from now on. If the CLA still doesn't show, I'd appreciate some help, as I've already signed it even via scanning and emailing. |
|
Additionally, if you want, I can drop this PR and recreate it with the former e-mail. |
|
landed in master. thanks |
It's now possible to pass a function to match the URL in $httpBackend mocked
expectations. This gives a more sophisticate control over the URL matching
without requiring complex RegExp mantainance or the workaround of creating
an object with a
testfunction in order to mimic RegExp interface. Docswere also updated.
This approach was suggested in this thread