Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngClass doesn't work with ngInclude anymore #4169

Closed
27leaves opened this issue Sep 26, 2013 · 6 comments
Closed

ngClass doesn't work with ngInclude anymore #4169

27leaves opened this issue Sep 26, 2013 · 6 comments

Comments

@27leaves
Copy link

I updated from 1.0.7 to 1.2.0RC2 and noticed that the ng-class doesn't work together with ng-include.

I had to change

template = '<span class="list-icon-small grey" ng-include="\'assets/icons/icons-background.svg\'" ng-class="{show: !isPending}" />'

to

template = '<span ng-class="{show: !isPending}"><span class="list-icon-small grey" ng-include="\'assets/icons/icons-background.svg\'" /></span>'

ng-include worked always, just the ng-class didn't work anymore.

@petebacondarwin
Copy link
Member

Have you checked whether this is relevant: #3727 ?

@petebacondarwin
Copy link
Member

and this one #4023 ?

@ghost ghost assigned matsko Sep 26, 2013
@27leaves
Copy link
Author

Yeah, I don't use ngAnimate in my application.

@petebacondarwin
Copy link
Member

But the animation changes have made differences to how the ngClass directive works internally...

@rodyhaddad
Copy link
Contributor

Try testing it with the latest snapshot,

This is the same as #3991 (already fixed)

@27leaves
Copy link
Author

Oh you were right! With the latest snapshot it works!
Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants