Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ng-include directives are not expanded when transcluded #3573

Closed
cdmckay opened this issue Aug 14, 2013 · 13 comments
Closed

ng-include directives are not expanded when transcluded #3573

cdmckay opened this issue Aug 14, 2013 · 13 comments
Assignees
Milestone

Comments

@cdmckay
Copy link

cdmckay commented Aug 14, 2013

When I upgraded to 1.2.0rc1 my ng-include directives are no longer expanded when transcluded into a ng-transclude.

Here's the Plunk:
http://plnkr.co/edit/NHlNI8bdpGX7ibBoDzcx?p=preview

@hccampos
Copy link

+1

@Carl012
Copy link

Carl012 commented Aug 15, 2013

I'd guess this could be the root cause for #3581 and #3584...

I've been unable to get ng-include to work with ng-switch. Same behavior it seems...

@matb33
Copy link

matb33 commented Aug 15, 2013

Same... also unable to get ng-include working with ng-switch

@cdmckay
Copy link
Author

cdmckay commented Aug 15, 2013

For people who need an ngInclude workaround badly (like me) here's the working 1.0.7 version that you can plop into your 1.2.0rc1 app (it doesn't support animation):
https://gist.github.com/cdmckay/6238612

@XtraKrispi
Copy link

There is a similar issue (if not the same) with ng-view inside a transcluded directive.

@ghost ghost assigned matsko Aug 15, 2013
@mhevery
Copy link
Contributor

mhevery commented Aug 15, 2013

@matsko Please add test case for this use case when you revert the ng-include/ng-view manual transclusion.

@kevin-smets
Copy link

This works with the latest snapshot!

http://plnkr.co/edit/TlDolruADXdT4sUPEaiE?p=preview

@cdmckay thx for the fix, that also worked :)

@jordanburke
Copy link

This works in 1.1.5 if you want animations for the time being (what I'm doing).

@matsko
Copy link
Contributor

matsko commented Sep 4, 2013

What about 1.2rc2? Can anyone check that out?

@IgorMinar
Copy link
Contributor

works with rc.2, closing.

@kirkhoff
Copy link

I'm on rc.2 and it's not working. When switching between multiple elements, an element with ng-include will not be switched and seems to be duplicated in the dom.

@homerjam
Copy link

I think this relates: I'm on 1.2.4 and using ng-if within a template that I'm linking/transcluding in a directive and its not working. I assuming that the ng-if is not being triggered at the right time?? But I've tried pre/post linking in the compile function with no luck...

So yea, doesn't seem to work in 1.2.4.

@IgorMinar
Copy link
Contributor

can you please open a new issue and create a plunker that reproduces the problem? thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests