Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

squash! wip #3537

Closed
wants to merge 1 commit into from
Closed

squash! wip #3537

wants to merge 1 commit into from

Conversation

chirayuk
Copy link
Contributor

No description provided.

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@ghost ghost assigned IgorMinar Aug 10, 2013
@IgorMinar IgorMinar mentioned this pull request Aug 10, 2013
Closed
IgorMinar pushed a commit to IgorMinar/angular.js that referenced this pull request Aug 10, 2013
@chirayuk @IgorMinar
fix($compile): correct controller instantiation for async directives
d32aa8d 
This fixes regression introduced by angular#3514 (5c56011) - this commit is being
reverted here and a better fix is included.

The regression caused the controller to be instantiated before the isolate scope
was initialized.

Closes angular#3493
Closes angular#3482
Closes angular#3537
@IgorMinar
Copy link
Contributor

closing in favor of #3540

@IgorMinar IgorMinar closed this Aug 10, 2013
chirayuk added a commit that referenced this pull request Aug 12, 2013
@chirayuk @IgorMinar
fix($compile): correct controller instantiation for async directives
c173ca4 
This fixes regression introduced by #3514 (5c56011) - this commit is being
reverted here and a better fix is included.

The regression caused the controller to be instantiated before the isolate scope
was initialized.

Closes #3493
Closes #3482
Closes #3537
Closes #3540
chirayuk added a commit to chirayuk/angular.js that referenced this pull request Aug 21, 2013
@chirayuk
fix($compile): correct controller instantiation for async directives
51d3224 
This fixes regression introduced by angular#3514 (9c51d50) - this commit is being
reverted here and a better fix is included.

The regression caused the controller to be instantiated before the isolate scope
was initialized.

Closes angular#3493
Closes angular#3482
Closes angular#3537
Closes angular#3540
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@IgorMinar IgorMinar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chirayuk @mary-poppins @IgorMinar