This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): remove prepare classes with multiple structural anima… #16681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gkalpak
reviewed
Sep 4, 2018
| extraClasses = (extraClasses ? (extraClasses + ' ') : '') + NG_ANIMATE_CLASSNAME; | ||
| var cacheKey = $$animateCache.cacheKey(node, event, extraClasses, options.removeClass); | ||
| var cacheKey = $$animateCache.cacheKey(element[0], animationEntry.event, extraClasses, options.removeClass); |
There was a problem hiding this comment.
AFAICT, element could also be a DOM node (in which case element[0] will be undefined), no?
There was a problem hiding this comment.
As far as I can see, at this point it's already normalized to be a DOM node
There was a problem hiding this comment.
Yeah, looking at it again, it seems that element is treated as a jqLite/jQuery element. So, it's fine.
test/ngAnimate/integrationSpec.js
Outdated
| module('ngAnimateMock'); | ||
| inject(function($animate, $compile, $rootScope, $rootElement, $document, $$animateCache) { | ||
| element = jqLite( | ||
| // Class animation pn parent element is neeeded so the child elements get the prepare class |
test/ngAnimate/integrationSpec.js
Outdated
|
|
||
| $compile(element)($rootScope); | ||
| // $rootScope.cond = false; | ||
| // $rootScope.$digest(); |
gkalpak
approved these changes
Sep 5, 2018
|
Sorry for answering late (had a week off). Thanks for refining and merging this issue @Narretz. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions
Closes #16677
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: