This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): throw error in $onChanges immediately #16492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
approved these changes
Mar 16, 2018
| @@ -1562,14 +1562,11 @@ function $CompileProvider($provide, $$sanitizeUriProvider) { | |||
| try { | |||
| onChangesQueue[i](); | |||
| } catch (e) { | |||
| errors.push(e); | |||
There was a problem hiding this comment.
You can get rid of the errors variable altogether.
This brings it in line with how we throw errors in a digest cycle. Closes angular#15578
Narretz
force-pushed
the
fix-onchanges-error
branch
from
5a80436 to
45dd445
Compare
This was referenced Mar 22, 2018
This was referenced Apr 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings it in line with how we throw errors in a digest cycle.
Closes #15578
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: