From af731354b0b600f87f15e1573e64a7f7acc70f3d Mon Sep 17 00:00:00 2001 From: neilmcgibbon Date: Fri, 2 Aug 2013 14:57:58 +0100 Subject: [PATCH] fix(input): fix the email regex to accept TLDs up to 6 characters long The input field email regex does't not match long domain extensions. This commit extends the email regexp to take a 6 character TLD. Example 6-character TLDs include .museum and .travel - (e.g. allabout.travel). --- src/ng/directive/input.js | 2 +- test/ng/directive/inputSpec.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ng/directive/input.js b/src/ng/directive/input.js index af028fd52923..f5d30a3e6c36 100644 --- a/src/ng/directive/input.js +++ b/src/ng/directive/input.js @@ -1,7 +1,7 @@ 'use strict'; var URL_REGEXP = /^(ftp|http|https):\/\/(\w+:{0,1}\w*@)?(\S+)(:[0-9]+)?(\/|\/([\w#!:.?+=&%@!\-\/]))?$/; -var EMAIL_REGEXP = /^[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,4}$/; +var EMAIL_REGEXP = /^[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,6}$/; var NUMBER_REGEXP = /^\s*(\-|\+)?(\d+|(\d*(\.\d*)))\s*$/; var inputType = { diff --git a/test/ng/directive/inputSpec.js b/test/ng/directive/inputSpec.js index 36fb754d580c..8f18964e0641 100644 --- a/test/ng/directive/inputSpec.js +++ b/test/ng/directive/inputSpec.js @@ -748,6 +748,7 @@ describe('input', function() { it('should validate email', function() { expect(EMAIL_REGEXP.test('a@b.com')).toBe(true); + expect(EMAIL_REGEXP.test('a@b.museum')).toBe(true); expect(EMAIL_REGEXP.test('a@B.c')).toBe(false); }); });