From 10da625ed93511dbf5d4e61ca4e42f6f2d478959 Mon Sep 17 00:00:00 2001 From: Vojta Jina Date: Fri, 8 Jul 2011 12:18:26 +0200 Subject: [PATCH] fix:jqLite: Normalize non-existing attributes to undefined as jQuery jqLite was returning null, but jQuery returns undefined --- src/jqLite.js | 4 +++- test/jqLiteSpec.js | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/jqLite.js b/src/jqLite.js index 5e9d777a981e..a2dc02cd33ce 100644 --- a/src/jqLite.js +++ b/src/jqLite.js @@ -266,7 +266,9 @@ forEach({ } else if (element.getAttribute) { // the extra argument "2" is to get the right thing for a.href in IE, see jQuery code // some elements (e.g. Document) don't have get attribute, so return undefined - return element.getAttribute(name, 2); + var ret = element.getAttribute(name, 2); + // normalize non-existing attributes to undefined (as jQuery) + return ret === null ? undefined : ret; } }, diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js index fafe7f2adf26..2c05a7e56ed7 100644 --- a/test/jqLiteSpec.js +++ b/test/jqLiteSpec.js @@ -162,6 +162,10 @@ describe('jqLite', function(){ expect(select.attr('multiple')).toEqual(true); }); + it('should return undefined for non-existing attributes', function() { + var elm = jqLite('
a
'); + expect(elm.attr('non-existing')).toBeUndefined(); + }); });