This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(application_factory): add missing @MirrorsUsed targets #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Could you please rewrite the commit comment according to https://github.com/angular/angular.dart/blob/master/CONTRIBUTING.md#commit |
blois
changed the title
blois
changed the title
|
Ah! Hadn't seen that, thanks for pointing it out. I think it's in-sync with the guidelines now. |
|
now ? have you forgotten to (force) push. Should be like "fix(dynamicApp): ..." |
A couple of types were missing for @MirrorsUsed when compiling with dart2js and using the dynamic app.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of types were missing for @MirrorsUsed when compiling with dart2js and using the dynamic app.
This addresses the question at:
https://groups.google.com/forum/#!topic/angular-dart/DMJZ8fX9oqA
Note that this only appears in the examples if the @MirrorsSyntax is being used:
@MirrorsUsed(
targets: const [ 'Item' ],
override: '*')
import 'dart:mirrors';
This impacts people using the previous syntax who have not (or are not) migrated to transformers.