Change assertion apis for http backend to define the assertion on flush

[IgorMinar]

instead of

backend.expectGET('/foo').respond('some response');
// do stuff
backend.flush()

do

// do stuff
backend.flushGET('/foo', 'some response')

Benefits:

• makes tests much easier to follow
• reduces the amount of code developer needs to write
• gives control over the order in which requests should be flushed

[mhevery]

👍

[vsavkin]

I'd like to work on it

[vsavkin]

I looked a bit into it. To implement this kind of API, MockHttpBackend will have to change in a significant way.

Right now MockHttpBackend throws when you call it with an unexpected request.

backend("GET", /some"); //throws here if `/some` has not been defined

To make the API change possible MockHttpBackend will have to run this check when you call flush.

backend("GET", /some"); //no problem, just records the request
backend.flush(); //throws here

This is a breaking change.

If the breaking change is not an option, there is another way to make tests more readable, by introducing some sort of autoFlush option.

backend.autoFlush = true; //it's done once somewhere in a beforeEach

backend.expect('GET', '/some').respond(200, 'success');
backend("GET", /some"); //calls the response function right away. So no need to call `flush`.

[IgorMinar]

We've been looking into this on the JS side as well and concluded that the
breaking change is too big for v1.x.

I however urge you to make this change before cutting v1.0. The benefits of
this change on usability and readability of the test code are huge.

On Fri, Jun 20, 2014 at 9:50 AM, Victor Savkin [email protected]
wrote:

I looked a bit into it. To implement this kind of API, MockHttpBackend
will have to change in a significant way.

Right now MockHttpBackend throws when you call it with an unexpected
request.

backend("GET", /some"); //throws here if /some has not been defined

To make the API change possible MockHttpBackend will have to run this
check when you call flush.

backend("GET", /some"); //no problem, just records the request
backend.flush(); //throws here

This is a breaking change.

If the breaking change is not an option, there is another way to make
tests more readable, by introducing some sort of autoFlush option.

backend.autoFlush = true; //it's done once somewhere in a beforeEach

backend.expect('GET', '/some').respond(200, 'success');
backend("GET", /some"); //calls the response function right away. So no need to call flush.

—
Reply to this email directly or view it on GitHub
#900 (comment)
.

[vsavkin]

Yup, it does make tests easier to follow.

I can submit a PR with the change if it is OK with everyone.