This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(relative_url_resolver): Fix match of CSS urls to match only first url #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -242,7 +242,7 @@ void main() { | |||
| _run_resolver(useRelativeUrls: false); | |||
| }); | |||
|
|
|||
| describe('url_resolver uri rewrite', () { | |||
| group('url_resolver', () { | |||
There was a problem hiding this comment.
Why change describe to group?
There was a problem hiding this comment.
Sorry jumping between unittest and jasmine syntax too much. I'll change it back to describe.
chirayuk
pushed a commit
to chirayuk/angular.dart
that referenced
this pull request
Mar 30, 2015
… url Change CSS URL matcher to be lazy instead of greedy. This fixes css url matching where minification is involved and matches too much. Also escape parenthesis in a URL test as it creates invalid CSS imports as defined here http://www.w3.org/TR/CSS2/syndata.html#value-def-uri Closes dart-archive#1697
… url Change CSS URL matcher to be lazy instead of greedy. This fixes css url matching where minification is involved and matches too much. Also escape parenthesis in a URL test as it creates invalid CSS imports as defined here http://www.w3.org/TR/CSS2/syndata.html#value-def-uri
TedSander
force-pushed
the
RegExRelativeFix
branch
from
1d9e1f2 to
bdeeee1
Compare
|
Done Switched to Jasmine Syntax. |
chirayuk
pushed a commit
that referenced
this pull request
Mar 31, 2015
… url Change CSS URL matcher to be lazy instead of greedy. This fixes css url matching where minification is involved and matches too much. Also escape parenthesis in a URL test as it creates invalid CSS imports as defined here http://www.w3.org/TR/CSS2/syndata.html#value-def-uri Closes #1697
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change CSS URL matcher to be lazy instead of greedy. This fixes css url
matching where minification is involved and matches too much. Also escape
parenthesis in a URL test as it creates invalid CSS imports as defined here
http://www.w3.org/TR/CSS2/syndata.html#value-def-uri