Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Expression Generator Transformer does not respect relative resources #1649

Closed
TedSander opened this issue Jan 18, 2015 · 0 comments
Closed

Comments

@TedSander
Copy link
Contributor

Any templates that are defined as being relative to the controller are not parsed by the expression generator transformer. The transformer does not respect the logic used by the TypeRelativeUriGenerator. A workaround is to specify every template used in this manner, but it can mean defining 100s of templates in the pubspec.yaml.

TedSander pushed a commit to TedSander/angular.dart that referenced this issue Jan 18, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other
transformers. This allows other transformers such as the ExpressionGenerator
and later the TemplateCacheGenerator to find relative resources.

Closes dart-archive#1649
TedSander pushed a commit to TedSander/angular.dart that referenced this issue Jan 27, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other
transformers. This allows other transformers such as the ExpressionGenerator
and later the TemplateCacheGenerator to find relative resources.

Fixes asset resolution according to Barback rules which are defined here:
http://goo.gl/YDMRc2 specifically library assets are defined with packages
being in the URI and all other resources are considered web resources.

Closes dart-archive#1649, dart-archive#1651
rkirov pushed a commit that referenced this issue Jan 28, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other
transformers. This allows other transformers such as the ExpressionGenerator
and later the TemplateCacheGenerator to find relative resources.

Fixes asset resolution according to Barback rules which are defined here:
http://goo.gl/YDMRc2 specifically library assets are defined with packages
being in the URI and all other resources are considered web resources.

Closes #1649, #1651
rkirov pushed a commit that referenced this issue Jan 28, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other
transformers. This allows other transformers such as the ExpressionGenerator
and later the TemplateCacheGenerator to find relative resources.

Fixes asset resolution according to Barback rules which are defined here:
http://goo.gl/YDMRc2 specifically library assets are defined with packages
being in the URI and all other resources are considered web resources.

Closes #1649, #1651
rkirov pushed a commit that referenced this issue Jan 28, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other
transformers. This allows other transformers such as the ExpressionGenerator
and later the TemplateCacheGenerator to find relative resources.

Fixes asset resolution according to Barback rules which are defined here:
http://goo.gl/YDMRc2 specifically library assets are defined with packages
being in the URI and all other resources are considered web resources.

Closes #1649, #1651
rkirov pushed a commit that referenced this issue Feb 2, 2015
Extracts logic used in the TypeRelativeUriGenerator to be used in other
transformers. This allows other transformers such as the ExpressionGenerator
and later the TemplateCacheGenerator to find relative resources.

Fixes asset resolution according to Barback rules which are defined here:
http://goo.gl/YDMRc2 specifically library assets are defined with packages
being in the URI and all other resources are considered web resources.

Closes #1649, #1651
@rkirov rkirov closed this as completed in 8d36167 Feb 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant