This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 248
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(url_resolver): changes _baseUri to support non http schemes.
Adds support for Chrome Apps because Uri.base.origin is limited to scheme that start with http or https.
- Loading branch information
Showing
1 changed file
with
14 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d929109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit made angular dart applications unusable for Cordova / PhoneGap as they load resources locally (file:///url_to_resource).
Is there any solution for this problem besides providing custom implementation for ResourceUrlResolver through DI?
d929109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should allow empty authority if the scheme is file. Should be a pretty straighforward change.
Also these failures mean our test coverage is lacking. So we need tests covering the major use cases - web, chrome apps, Cordova etc.
@chirayu do you agree?
d929109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can update the code to allow an empty authority in the case where scheme is file