fix(eval access): Do not crash on null cached value

Fixes #424
dart-archive · Feb 5, 2014 · bbcbd3e · bbcbd3e
1 parent 1ab385e
commit bbcbd3e
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/lib/core/parser/eval_access.dart b/lib/core/parser/eval_access.dart
@@ -70,7 +70,7 @@ abstract class AccessReflective {
     int cachedKind = _cachedKind;
     if (cachedKind == CACHED_MAP) return holder[name];
     var value = _cachedValue;
-    return (cachedKind == CACHED_FIELD)
+    return (cachedKind == CACHED_FIELD && value != null)
         ? value.getField(symbol).reflectee
         : value;
   }

diff --git a/test/directive/ng_model_spec.dart b/test/directive/ng_model_spec.dart
@@ -7,6 +7,11 @@ main() =>
 describe('ng-model', () {
   TestBed _;
 
+  beforeEach(module((Module module) {
+    module
+      ..type(ControllerWithNoLove);
+  }));
+
   beforeEach(inject((TestBed tb) => _ = tb));
 
   describe('type="text" like', () {
@@ -600,4 +605,25 @@ describe('ng-model', () {
     }));
   });
 
+  describe('error messages', () {
+    it('should produce a useful error for bad ng-model expressions', () {
+      expect(async(() {
+        _.compile('<div no-love><textarea ng-model=ctrl.love probe="loveProbe"></textarea></div');
+        Probe probe = _.rootScope['loveProbe'];
+        TextAreaElement inputElement = probe.element;
+
+        inputElement.value = 'xzy';
+        _.triggerEvent(inputElement, 'change');
+        _.rootScope.$digest();
+      })).toThrow('love');
+
+    });
+  });
 });
+
+@NgController(
+    selector: '[no-love]',
+    publishAs: 'ctrl')
+class ControllerWithNoLove {
+  var apathy = null;
+}