fix(tagging compiler): Sibling templates

dart-archive · Mar 17, 2014 · 167b490 · 167b490
1 parent 79fe1f8
commit 167b490
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/lib/core_dom/tagging_compiler.dart b/lib/core_dom/tagging_compiler.dart
@@ -91,7 +91,7 @@ class TaggingCompiler implements Compiler {
             (templateCursor.current.parentNode as dom.Element).classes.add('ng-binding');
           }
           directParentElementBinder.addText(
-              new TaggedTextBinder(elementBinder, 0 /* TODO */));
+              new TaggedTextBinder(elementBinder, domCursor.index));
         } else if(!(node.parentNode != null &&
                     templateCursor.current.parentNode != null)) {
           // Always add an elementBinder for top-level text.

diff --git a/lib/directive/ng_repeat.dart b/lib/directive/ng_repeat.dart
@@ -105,6 +105,7 @@ class NgRepeatDirective {
                     this.filters);
 
   set expression(value) {
+    assert(value != null);
     _expression = value;
     if (_watch != null) _watch.remove();
     Match match = _SYNTAX.firstMatch(_expression);

diff --git a/test/core_dom/compiler_spec.dart b/test/core_dom/compiler_spec.dart
@@ -108,6 +108,17 @@ void main() {
             '</div>');
     });
 
+    it('should compile a sibling template directive', () {
+      var element = $(_.compile(
+        '<div ng-model="selected">'
+          '<option value="">blank</option>'
+          '<div ng-repeat="value in [1,2]" ng-value="value">{{value}}</div>'
+      '</div>'));
+
+      _.rootScope.apply();
+      expect(element.text()).toEqual('blank12');
+    });
+
     it('should compile repeater with children', inject((Compiler $compile) {
       var element = $(_.compile('<div><div ng-repeat="item in items"><div ng-bind="item"></div></div></div>'));