Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy): Fix base href for user pages #965

Merged
merged 2 commits into from
Jun 1, 2016
Merged

fix(deploy): Fix base href for user pages #965

merged 2 commits into from
Jun 1, 2016

Conversation

rockwotj
Copy link
Contributor

Deploying to user pages would change the base URL to something like "/angular.github.io/" instead of the correct "/" due to the URL structure for user pages.

Deploying to user pages would change the base URL
to something like "/angular.github.io/" instead of
the correct "/" due to the URL structure for user pages.
@rockwotj
Copy link
Contributor Author

Any idea why the build is failing on nvm install $NODE_VERSION?

@filipesilva
Copy link
Contributor

@rockwotj the fail must be a fluke, I'll restart it. Thanks for making this PR btw!

@filipesilva
Copy link
Contributor

@rockwotj the CI is showing a lint error, can you fix it?

/home/travis/build/angular/angular-cli/tests/acceptance/github-pages-deploy.spec.js
  109:42  error  Strings must use singlequote  quotes

@rockwotj
Copy link
Contributor Author

rockwotj commented Jun 1, 2016

@filipesilva it passes now!

@filipesilva filipesilva merged commit 424cff2 into angular:master Jun 1, 2016
devCrossNet pushed a commit to devCrossNet/universal-cli that referenced this pull request Jun 9, 2016
* fix(deploy): Fix base href for user pages

Deploying to user pages would change the base URL
to something like "/angular.github.io/" instead of
the correct "/" due to the URL structure for user pages.

* style(lint): use single quotes for string
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants