Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): add separate config flags to toggle build #805

Closed
jeffbcross opened this issue May 17, 2016 · 7 comments
Closed

feat(mobile): add separate config flags to toggle build #805

jeffbcross opened this issue May 17, 2016 · 7 comments
Assignees
Labels
effort1: easy (hours) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@jeffbcross
Copy link
Contributor

This suggestion was brought up by @kara.

During development, compiling the App Shell can be a burden: It takes a while to bundle files into a single concatenated script, the compilation often fails because of a missing provider or other non-prerender-friendly code. However, compiling during development also has advantages, like making sure the transition from shell to real app is seamless, making sure compilation works, etc.

So it would be nice to be able to easily disable app shell compilation during dev build.

Right now, the only option in angular-cli.json for mobile projects is a single mobile: true setting. This could be expanded to be an object with more granular configuration, one of which could modify what mobile pieces are built during dev and prod:

angular-cli.json

mobile: {
  dev: {
    buildAppShell: true,
    buildServiceWorker: false,
    buildAppManifest: true
  },
  prod: {
    buildAppShell: true,
    buildServiceWorker: false,
    buildAppManifest: true
  }
}

The downside to this design is that the build becomes more complicated. For example, right now, Service Worker assumes that App Shell is being built, and therefore only caches the bundled JS plus static non-JS assets. With more configuration, the Service Worker would have to figure out which JS tree it should be caching.

@jeffbcross jeffbcross self-assigned this May 17, 2016
@filipesilva filipesilva added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jun 4, 2016
@filipesilva
Copy link
Contributor

@jeffbcross is this still an issue on the webpack branch?

@jeffbcross
Copy link
Contributor Author

@filipesilva this would still be a nice feature to have.

@hansl hansl modified the milestone: RC1 Nov 11, 2016
@CharlBest
Copy link

I can't wait for this feature especially after the Angular Universal integration as well. Creating progressive web app will be so easy and integrated nicely. So excited!!

@filipesilva
Copy link
Contributor

Closing as it this isn't being acted on anymore. See #2228 for context.

@CharlBest
Copy link

Haha. I caused this issue to close. Sort of by saying something. But I understand @filipesilva. Only so much time :) Thanks for the reply. You guys are doing awesome work!!

@filipesilva
Copy link
Contributor

Kinda, yeah :D. When you commented I got an email that prompted me to review it.

Glad you're enjoying the CLI!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort1: easy (hours) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

4 participants