-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): add separate config flags to toggle build #805
Comments
@jeffbcross is this still an issue on the webpack branch? |
@filipesilva this would still be a nice feature to have. |
I can't wait for this feature especially after the Angular Universal integration as well. Creating progressive web app will be so easy and integrated nicely. So excited!! |
Closing as it this isn't being acted on anymore. See #2228 for context. |
Haha. I caused this issue to close. Sort of by saying something. But I understand @filipesilva. Only so much time :) Thanks for the reply. You guys are doing awesome work!! |
Kinda, yeah :D. When you commented I got an email that prompted me to review it. Glad you're enjoying the CLI! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This suggestion was brought up by @kara.
During development, compiling the App Shell can be a burden: It takes a while to bundle files into a single concatenated script, the compilation often fails because of a missing provider or other non-prerender-friendly code. However, compiling during development also has advantages, like making sure the transition from shell to real app is seamless, making sure compilation works, etc.
So it would be nice to be able to easily disable app shell compilation during dev build.
Right now, the only option in angular-cli.json for mobile projects is a single
mobile: true
setting. This could be expanded to be an object with more granular configuration, one of which could modify what mobile pieces are built during dev and prod:angular-cli.json
The downside to this design is that the build becomes more complicated. For example, right now, Service Worker assumes that App Shell is being built, and therefore only caches the bundled JS plus static non-JS assets. With more configuration, the Service Worker would have to figure out which JS tree it should be caching.
The text was updated successfully, but these errors were encountered: