Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating autoprefixer to v7.1.x and postcss v6.0.x #7271

Closed
JulienBourgain opened this issue Aug 4, 2017 · 9 comments
Closed

Updating autoprefixer to v7.1.x and postcss v6.0.x #7271

JulienBourgain opened this issue Aug 4, 2017 · 9 comments
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity2: inconvenient

Comments

@JulienBourgain
Copy link

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request

Versions.

@angular/[email protected]

Desired functionality.

In my project, i use css-grids and the default option in autoprefixer 6 is grid: true
In autoprefixer 7, it's grid: false

i think there is some other improvements

Mention any other details that might be useful.

@clydin
Copy link
Member

clydin commented Aug 4, 2017

This is waiting on cssnano 4.0 to be released to have a full postcss 6 pipeline.

@Brocco Brocco self-assigned this Aug 17, 2017
@Brocco Brocco added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity2: inconvenient labels Aug 17, 2017
@mgol
Copy link
Member

mgol commented Dec 7, 2017

Note that Autoprefixer 7 disables CSS Grid prefixes for IE by default so unless CLI passes the option explicitly (and unless there are more breaking changes there) the update to Autoprefixer 7 will be breaking and will require a major version bump of Angular CLI.

@kylecordes
Copy link

@mgol I wonder if would be sufficient to simply set grid: true, if that will be enough to make it possible to move up to v7, without having to simultaneously solve the problem of making autoprefixer configurable.

@mgol
Copy link
Member

mgol commented Dec 20, 2017

@kylecordes That might be worth it. From what I see in the changelog, this is the only breaking change aparts from dropping old Node versions that CLI doesn't support anyway.

It'd still be worth it to be able to configure PostCSS plugins but that's a separate issue.

@kylecordes
Copy link

@mgol I have a workaround in progress that does this and appears to work fine. Writeup coming soon.

@clydin
Copy link
Member

clydin commented Dec 20, 2017

@mgol @kylecordes PRs are welcome for the autoprefixer upgrade. As mentioned grid: true would need to be set to ensure compatibility.

@hansl hansl unassigned Brocco Feb 6, 2018
@DaSchTour
Copy link

From what I see we are now at autoprefixer 8.2.5 and there is already a version 9. I think regarding this issue #11731 and #10076 it would be great to also introduce configuration for this in angular cli.

@alan-agius4
Copy link
Collaborator

These dependencies have been update

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent severity2: inconvenient
Projects
None yet
Development

No branches or pull requests

7 participants