Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular/cli): fix issue with console prompt bailing early #5218

Merged
merged 2 commits into from
Mar 8, 2017
Merged

fix(@angular/cli): fix issue with console prompt bailing early #5218

merged 2 commits into from
Mar 8, 2017

Conversation

delasteve
Copy link
Contributor

@delasteve delasteve commented Mar 4, 2017 •
edited
Loading

fixes #4614

// cc: @Brocco

@delasteve delasteve force-pushed the bug/overwrite-file branch 2 times, most recently from c33527f to 86d60bb Compare March 4, 2017 02:51
@delasteve delasteve mentioned this pull request Mar 4, 2017
Closed
@delasteve delasteve force-pushed the bug/overwrite-file branch 3 times, most recently from f92321f to e8ff334 Compare March 6, 2017 22:58
Brocco
Brocco suggested changes Mar 7, 2017
View reviewed changes
Copy link
Contributor

@Brocco Brocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in blueprints/component/index.ts will also need made for directives, pipes and possibly services.

@delasteve delasteve force-pushed the bug/overwrite-file branch from e8ff334 to 01628e9 Compare March 8, 2017 00:32
@Brocco Brocco merged commit 3515c3b into angular:master Mar 8, 2017
@delasteve delasteve mentioned this pull request Mar 13, 2017
Closed
@delasteve delasteve deleted the bug/overwrite-file branch March 16, 2017 22:07
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@delasteve
fix(@angular/cli): fix issue with console prompt bailing early (angul…
cd69373 
…ar#5218)

* fix(@angular/cli): fix issue with console prompt bailing early

fixes angular#4614

* fix(@angular/cli): fix declarable types not finding closest module

fixes angular#5127
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Brocco Brocco Brocco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate bails when overwriting files
3 participants
@delasteve @Brocco @googlebot