fix(eject): set ejected project to run webdriver-manager update as part of e2e npm script
#4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…part of `e2e` npm script
filipesilva
suggested changes
Feb 22, 2017
hansl
suggested changes
Feb 22, 2017
| @@ -434,6 +436,13 @@ export default Task.extend({ | |||
| Your package.json scripts needs to not contain a start script as it will be overwritten. | |||
| `); | |||
| } | |||
| if (scripts['pree2e'] && scripts['pree2e'] !== pree2eNpmScript && !force) { | |||
| // tslint:disable-next-line:max-line-length | |||
There was a problem hiding this comment.
You're using oneLine so you can put your string in multiple lines and they'll be joined. Remove this tslint exception.
There was a problem hiding this comment.
Fixing myself then committing.
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
…part of `e2e` npm script Closes angular#4920
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error you get with:
Because
webdriver-manager updatenever ran.--
This is based on old NPM
pree2eway.