fix(serve): allow relevant live-reload options to function #4744
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
@googlebot I approve the usage of my commit |
This is useful when you don't want the server to rebuild in the middle of something. A good example is when running e2e tests. Especially on larger suites, one would prefer to continue working while the build is tested without compromising tests. This will break tests on angular#4744. They should be adjusted to add the `--watch` flag since they depend on the live reload behaviour during `ng e2e`.
This is useful when you don't want the server to rebuild in the middle of something. A good example is when running e2e tests. Especially on larger suites, one would prefer to continue working while the build is tested without compromising tests. This will break tests on #4744. They should be adjusted to add the `--watch` flag since they depend on the live reload behaviour during `ng e2e`.
filipesilva
force-pushed
the
live-reload
branch
from
ac25cf0 to
bc39735
Compare
filipesilva
force-pushed
the
live-reload
branch
from
bc39735 to
0b062dd
Compare
This is useful when you don't want the server to rebuild in the middle of something. A good example is when running e2e tests. Especially on larger suites, one would prefer to continue working while the build is tested without compromising tests. This will break tests on angular#4744. They should be adjusted to add the `--watch` flag since they depend on the live reload behaviour during `ng e2e`.
) This provides implementations for the following serve command options: live-reload [boolean; default: true] -- flag to control the browser live reload capability live-reload-client [URL; default: ssl/host/port command options] -- specify the URL that the live reload browser client will use Closes angular#3361
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Followup from #3952
/cc @clydin