-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(serve): allow setting ssl certificate in angular-cli.json #4730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya, this is a nice solid PR.
It seems to need a rebase though, and it's failing on appveyor:
Running "tests\misc\ssl-default-config" (89 of 100)...
Last step took 0.02s...
Error: ENOENT: no such file or directory, open 'C:\Users\appveyor\AppData\Local\Temp\1\angular-cli-e2e-117116-1040-1qtheza.r92jnpzaor\test-project\angular-cli.json'
Test "tests\misc\ssl-default-config" failed...
ENOENT: no such file or directory, open 'C:\Users\appveyor\AppData\Local\Temp\1\angular-cli-e2e-117116-1040-1qtheza.r92jnpzaor\test-project\angular-cli.json'
Error: ENOENT: no such file or directory, open 'C:\Users\appveyor\AppData\Local\Temp\1\angular-cli-e2e-117116-1040-1qtheza.r92jnpzaor\test-project\angular-cli.json'
The error seems to be due to the config filename, probably because it needs a dot now (.angular-cli.json
). Not sure why travis didn't fail on that though.
I should mention that there is some time pressure to get this in due to RC0. I'm not sure we can add it afterwards since it does change the config api. |
6fca389
to
d20e1be
Compare
Currently users must use the --ssl, -ssl-cert, -ssl-key flags to run the server using an ssl certificate. This update allows users to set those options in default.serve so they can just run `ng serve` without any flags.
d20e1be
to
952500f
Compare
@itslenny I added my approval but it's contingent on CI passing, per usual. |
@filipesilva I got a failure on Travis that doesn't seem to be related to my change. Is this a known flaky test? It only failed in one of the environments.
|
Yes that test is flaky sometimes. I have ran into it today as well. I'll restart that job. |
@itslenny thanks for your work getting this in! |
…angular#4730) Currently users must use the --ssl, -ssl-cert, -ssl-key flags to run the server using an ssl certificate. This update allows users to set those options in default.serve so they can just run `ng serve` without any flags.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Currently users must use the --ssl, -ssl-cert, -ssl-key flags to run the
server using an ssl certificate. This update allows users to set
those options in default.serve so they can just run
ng serve
without anyflags.