-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bail out if output path is the root folder #4490
Bail out if output path is the root folder #4490
Conversation
…th=. would wipe out the entire root folder.
Seems sensible. Thanks :D |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Oh CLAbot, you're so silly, I just merge master in this PR before merging it. All good. |
This should also go in |
…r#4490) `ng serve` --output-path=. would wipe out the entire root folder.
…r#4490) `ng serve` --output-path=. would wipe out the entire root folder.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ng serve --output-path=.
would wipe out the entire root folder otherwise.This PR prevent issue #4481 from occurring, this closes #4481.