Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bail out if output path is the root folder #4490

Merged

Conversation

catull
Copy link
Contributor

@catull catull commented Feb 7, 2017

ng serve --output-path=. would wipe out the entire root folder otherwise.
This PR prevent issue #4481 from occurring, this closes #4481.

…th=. would wipe out the entire root folder.
@hansl
Copy link
Contributor

hansl commented Feb 7, 2017

Seems sensible. Thanks :D

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Feb 7, 2017
@hansl hansl merged commit 22f4bea into angular:master Feb 7, 2017
@hansl
Copy link
Contributor

hansl commented Feb 7, 2017

Oh CLAbot, you're so silly, I just merge master in this PR before merging it. All good.

@filipesilva
Copy link
Contributor

This should also go in ng build. I'll add a PR for it.

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Feb 8, 2017
@catull catull deleted the avoid-wiping-entire-project-root-directory branch February 8, 2017 15:17
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Feb 8, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
…r#4490)

`ng serve` --output-path=. would wipe out the entire root folder.
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Feb 9, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Feb 9, 2017
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
…r#4490)

`ng serve` --output-path=. would wipe out the entire root folder.
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli deleted my project folder
4 participants