fix(@angular/cli): add environment file to compilerHost #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brocco
suggested changes
Feb 7, 2017
| const { appConfig, projectRoot, buildOptions } = wco; | ||
|
|
||
| // Read the environment, and set it in the compiler host. | ||
| const appRoot = path.resolve(projectRoot, wco.appConfig.root); |
There was a problem hiding this comment.
Shouldn't wco.appConfig.root be appConfig.root since it was already destructured from wco? (same on the next 2 lines too)
hansl
force-pushed
the
environment-fix
branch
from
8797d50 to
ab80faf
Compare
Brocco
approved these changes
Feb 7, 2017
hansl
force-pushed
the
environment-fix
branch
2 times, most recently
from
2f5991b to
7ae5e0c
Compare
hansl
force-pushed
the
environment-fix
branch
from
7ae5e0c to
11526ef
Compare
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4375