feat(angular-cli): Add a postinstall warning for Node 4 deprecation. #4309
Conversation
hansl
requested review from
StephenFluin,
robwormald,
Brocco,
filipesilva and
juleskremer
hansl
force-pushed
the
node-deprecation
branch
2 times, most recently
from
24b2b45 to
8da772b
Compare
| Many of our dependencies are moving to deprecating Node 4 already and that would mean that we | ||
| could not update them to the latest versions which might have bug fixes and new useful features. | ||
|
|
||
| As a forewarning, We are also moving to "@angular/cli" with the next release, which will only |
There was a problem hiding this comment.
Should this be a separate check to see if the angular-cli package is in the package.json? That way, everyone will be notified that the package is moving, not just those on 4.x.
There was a problem hiding this comment.
Good point. We're still trying to figure out where to put those warnings, since post install might be too early and be missed out when looking at the console.
There was a problem hiding this comment.
Do we need this much detail? I think if we just keep it to You are running version x.x of Node, which will not be supported in future versions of the CLI. The official Node version that will be supported is 6.9 and greater.
There was a problem hiding this comment.
@StephenFluin missed that comment. Done.
hansl
force-pushed
the
node-deprecation
branch
from
8da772b to
4f4a804
Compare
hansl
force-pushed
the
node-deprecation
branch
2 times, most recently
from
1a29a2e to
4f57b38
Compare
|
LGTM from devrel |
BREAKING CHANGE: Node < 6.9 will be deprecated soon, and this will show a warning to users. Moving forward, that warning will be moved to an error with the next release.
hansl
force-pushed
the
node-deprecation
branch
from
4f57b38 to
b1c135c
Compare
…ngular#4309) BREAKING CHANGE: Node < 6.9 will be deprecated soon, and this will show a warning to users. Moving forward, that warning will be moved to an error with the next release.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
BREAKING CHANGE: Node < 6.9 will be deprecated soon, and this will show a warning to users. Moving forward, that warning will be moved to an error with the next release.