Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): fix new linting errors #4241

Merged
merged 1 commit into from
Jan 26, 2017

Conversation

filipesilva
Copy link
Contributor

The following linting errors appeared on master. I suppose it was due to a tslint update.

packages/@ngtools/json-schema/src/schema-tree.ts[34, 23]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/json-schema/src/schema-tree.ts[35, 21]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/json-schema/src/schema-tree.ts[250, 22]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/compiler_host.ts[103, 19]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/plugin.ts[50, 23]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/plugin.ts[51, 32]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/refactor.ts[33, 21]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/angular-cli/lib/webpack/compression-plugin.ts[29, 22]: Type number trivially inferred from a number literal, remove type annotation
packages/angular-cli/lib/webpack/compression-plugin.ts[30, 21]: Type number trivially inferred from a number literal, remove type annotation
tests/acceptance/get-dependent-files.spec.ts[3, 64]: trailing whitespace

The following linting errors appeared on master. I suppose it was due to a `tslint` update.

```
packages/@ngtools/json-schema/src/schema-tree.ts[34, 23]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/json-schema/src/schema-tree.ts[35, 21]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/json-schema/src/schema-tree.ts[250, 22]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/compiler_host.ts[103, 19]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/plugin.ts[50, 23]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/plugin.ts[51, 32]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/refactor.ts[33, 21]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/angular-cli/lib/webpack/compression-plugin.ts[29, 22]: Type number trivially inferred from a number literal, remove type annotation
packages/angular-cli/lib/webpack/compression-plugin.ts[30, 21]: Type number trivially inferred from a number literal, remove type annotation
tests/acceptance/get-dependent-files.spec.ts[3, 64]: trailing whitespace
```
@Brocco Brocco merged commit 76f8827 into angular:master Jan 26, 2017
@filipesilva filipesilva deleted the fix-new-lint-errors branch January 26, 2017 13:25
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
The following linting errors appeared on master. I suppose it was due to a `tslint` update.

```
packages/@ngtools/json-schema/src/schema-tree.ts[34, 23]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/json-schema/src/schema-tree.ts[35, 21]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/json-schema/src/schema-tree.ts[250, 22]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/compiler_host.ts[103, 19]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/plugin.ts[50, 23]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/plugin.ts[51, 32]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/@ngtools/webpack/src/refactor.ts[33, 21]: Type boolean trivially inferred from a boolean literal, remove type annotation
packages/angular-cli/lib/webpack/compression-plugin.ts[29, 22]: Type number trivially inferred from a number literal, remove type annotation
packages/angular-cli/lib/webpack/compression-plugin.ts[30, 21]: Type number trivially inferred from a number literal, remove type annotation
tests/acceptance/get-dependent-files.spec.ts[3, 64]: trailing whitespace
```
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants