-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): correctly load component stylesheets #3511
Conversation
Fixes 3534? |
@dave-kennedy, unrelated. |
/cc @filipesilva |
@clydin thanks for the PR. Yours seems better than mine. Could you add the same test that I added to my PR? That way we can avoid regressing over this big in the future. Thanks |
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Added your test. |
Okay you'll need to sign the CLA and everything is good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clydin can you squash the commits into a single one authored by you? That's what's messing up the CLA. |
CLAs look good, thanks! |
@filipesilva, that's annoying. Ok. Squashed. |
@clydin thank you, waiting on CI for merge. |
LGTM. Thanks! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Component styles were being generated as javascript due to the chaining of
css-loader
andraw-loader
. This is changed to only use thecss-loader
for global stylesheets (the behavior before PR #3402).If there is a desire/need to maintain the use of
css-loader
in all cases, theraw-loader
could be swapped with something along the lines ofexports-loader?module.exports.toString()
.