feat(cli): change generate --prefix option type from Boolean to string #3457
Conversation
use ``ng g c foo --prefix='bar'`` or ``ng g d foo --prefix='bar'`` in order to use another prefix than the one defined by default in angular-cli.json apps[0].prefix tslint rules "directive-selector" and "component-selector" can accept any array of prefix, and is therefore compatible with this approach this is a temporary solution pending angular#3452 closure
|
This is my first PR on angular-cli, and I don't understand for now why CI is not passing ... I ran all tests with npm test and everything was ok ... If someone could tell me what should I do to correct this, or if I missed some points about angular-cli testing ... Thanks. |
…ectives prefix This is not the final commit ! We still need to find an agreement on which solution to use between exported constants and comments, then, if the first one is choosed, move the associated code to utilities (see TODOs) and make the associated UTs. see angular#3452
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
Thanks @noelmace!!! |
…string (angular#3457) use ``ng g c foo --prefix='bar'`` or ``ng g d foo --prefix='bar'`` in order to use another prefix than the one defined by default in angular-cli.json apps[0].prefix tslint rules "directive-selector" and "component-selector" can accept any array of prefix, and is therefore compatible with this approach this is a temporary solution pending angular#3452 closure
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Use
ng g c foo --prefix='bar'orng g d foo --prefix='bar'in order to useanother prefix than the one defined by default in angular-cli.json apps[0].prefix
Any other options (--no-prefix or --prefix, without any value, using the default one in angular-cli.json) still work as expected and documented.
Tslint rules "directive-selector" and "component-selector" can accept any array of prefix, and is therefore compatible with this approach.
This could be a first solution to #3452.