fix(deploy): gh-pages deploy fail after repo create #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
reviewed
Dec 7, 2016
| @@ -216,7 +216,8 @@ const githubPagesDeployCommand = Command.extend({ | |||
| files = files.concat(`"${f}" `); | |||
| } | |||
| }); | |||
| return execPromise(`git rm -r ${files}`); | |||
| return execPromise(`git rm -r ${files}`) | |||
| .catch(() => Promise.resolve()); | |||
There was a problem hiding this comment.
Could you please replace this line with:
.catch(() => {
// Ignoring errors when trying to erase files.
});
Catches the error as they are no files to clean up on repo create. Closes angular#3385
rolyatsats
force-pushed
the
gh-pages-new-deploy-fail
branch
from
2fb1941 to
0e6813b
Compare
|
LGTM. Cheers! |
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
Catches the error as they are no files to clean up on repo create. Closes angular#3385
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches the error as they are no files to clean up on repo create.
Closes #3385