Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy): clean up gh-pages obsolete files (#3081) #3333

Merged
merged 1 commit into from
Dec 3, 2016

Conversation

rolyatsats
Copy link
Contributor

Prevents the gh-pages branch from growing indefinitely by cleaning up before copying new files.
Fixes #3081

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@rolyatsats
Copy link
Contributor Author

rolyatsats commented Dec 1, 2016

This process runs git ls-files, removes .gitignore and 404.html from the list, then passes this to git rm -r by wrapping each file path in double quotes such as:

git rm -r "style.css" "index.html" "main.js"

This works because the files are then added back when copying from dist before finally being committed.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 1, 2016
@rolyatsats rolyatsats force-pushed the fix-gh-pages-deploy-cleanup branch from 5a4e98f to 9fb8863 Compare December 1, 2016 09:10
Prevents the gh-pages branch from growing indefinitely by cleaning up before copying new files.

Fixes angular#3081
@rolyatsats rolyatsats force-pushed the fix-gh-pages-deploy-cleanup branch from 9fb8863 to ecdaee7 Compare December 1, 2016 09:22
@hansl
Copy link
Contributor

hansl commented Dec 3, 2016

LGTM. Thanks!

@hansl hansl merged commit 51869fb into angular:master Dec 3, 2016
@rolyatsats rolyatsats deleted the fix-gh-pages-deploy-cleanup branch December 3, 2016 20:05
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
…#3333)

Prevents the gh-pages branch from growing indefinitely by cleaning up before copying new files.

Fixes angular#3081
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github-pages:deploy doesn't clean up obsolete files
3 participants