Update Angular2 version to 2.2.3 #3295
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
@hansl Has the issue that made us lock the version been fixed? In that case we could change to |
| "@angular/forms": "2.2.3", | ||
| "@angular/http": "2.2.3", | ||
| "@angular/platform-browser": "2.2.3", | ||
| "@angular/platform-browser-dynamic": "2.2.3", | ||
| "@angular/router": "3.2.1", |
There was a problem hiding this comment.
@angular/router should be version 3.2.3 too
|
@grizzm0 I believe so. See angular/angular@64bd672 |
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@sarunint can you check the @googlebot reply please? |
|
@googlebot I'm OK with the commit |
|
@psantos10 I'm not sure why @googlebot is not responding. |
|
@sarunint Did you sign the CLA at https://cla.developers.google.com/ ? |
|
Googlebot is confused because there are multiple commits by different authors here. Can you squash to just @psantos10 please? |
|
Otherwise I'll just make the PR myself. |
Change router version to 3.2.3 chore(deps): update Angular versions to ^2.2.3 change version from 2.2.3 to ^2.2.3
psantos10
force-pushed
the
update_angular_version
branch
from
c231ce5 to
c9f0178
Compare
|
CLAs look good, thanks! |
|
@hansl squashed |
|
@grizzm0 fix the version. We are working on making loose versions work again, but in the meantime we have to carefully update. |
| "@angular/compiler": "2.2.1", | ||
| "@angular/compiler-cli": "2.2.1", | ||
| "@angular/core": "2.2.1", | ||
| "@angular/compiler": "^2.2.3", |
There was a problem hiding this comment.
Lock the version please. Here and everywhere.
|
@psantos10 thanks for the squash. GoogleBot is happier :) Just need to fix the version and I'll get this in. Cheers! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Update ng to use Angular version 2.2.3 instead of 2.2.1