Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ng new): Make CLI available without install #3126

Closed
wants to merge 1 commit into from

Conversation

Meligy
Copy link
Contributor

@Meligy Meligy commented Nov 13, 2016

This small change will allow consumers of the CLI to have their projects shared with anyone, even if they don't have the CLI installed.

They just clone, and run npm install, and then they can all interesting stuff they want directly from the CLI by using npm run ng -- instead of ng.

It also helps people who may have multiple projects created by the CLI not all upgraded to the latest version, matching their global install.

this small change will allow consumers of the CLI to have their projects shared with anyone, even if they don't have the CLI installed.

They just clone, and run `npm install`, and then they can all interesting stuff they want directly from the CLI by using `npm run ng -- ` instead of `ng`.

It also helps people who may have multiple projects created by the CLI not all upgraded to the latest version, matching their global install.
@filipesilva
Copy link
Contributor

This might work for some commands but it's not guaranteed to work for every one.

@hansl @Brocco what do you think?

@Meligy
Copy link
Contributor Author

Meligy commented Nov 22, 2016

I use it this way in several projects on Mac and Windows and been doing so for months (it's the first change I make after ng new).

Note that this is how npm start and npm test work today.

@Meligy
Copy link
Contributor Author

Meligy commented Nov 28, 2016

@hansl @Brocco would you guys think this is an OK default?
(It seems to be getting a few +1`s)

The PR doesn't try to push using it as front and center best practice or anything. It's just a nice reliable option when people have the CLI version it lands in, and other more recent versions.

@hansl
Copy link
Contributor

hansl commented Dec 3, 2016

I'm okay with this, although this will break in the future when we actually remove the CLI from dependencies of projects.

@filipesilva @Brocco do either of you have a problem with this change?

@filipesilva
Copy link
Contributor

I am ok with it.

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
This small change will allow consumers of the CLI to have their projects shared with anyone, even if they don't have the CLI installed.

They just clone, and run `npm install`, and then they can all interesting stuff they want directly from the CLI by using `npm run ng -- ` instead of `ng`.

It also helps people who may have multiple projects created by the CLI not all upgraded to the latest version, matching their global install.

Close angular#3126
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants