-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): add sourcemap option #3113
Conversation
78f9df9
to
4524805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but travis failing.
open?: boolean; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this empty line, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Add `--no-sourcemap` option to `ng build/serve/test`. Disabling sourcemaps can help with build speeds. My tests on a medium project shoul a 11.5% improvement on initial builds, and a 37% improvement on rebuilds. Disabling sourcemaps will make debugging harder, since it makes line information very innacurate. Partially address angular#1980
4524805
to
b331ecf
Compare
Should disabling sourcemaps also reduce the bundle size? I am using lazy loading and with --prod and --aot options the total size of all bundles is ~14mb with one of the bundles (0.xxxxxxxx.bundle.js) having size of ~8mb. The build process takes 20 minutes. |
Add `--no-sourcemap` option to `ng build/serve/test`. Disabling sourcemaps can help with build speeds. My tests on a medium project shoul a 11.5% improvement on initial builds, and a 37% improvement on rebuilds. Disabling sourcemaps will make debugging harder, since it makes line information very innacurate. Partially address angular#1980
@filipesilva I just tried no-sourcemap using below command ng build --aot --prod --no-sourcemap, the total bundles size which was 14mb with previous version, is now 38.3 mb though the build which previousl took 20 minutes is now very quick. |
@filipesilva Isn't sourcemap only used for dev/debug purposes? My main.bundle.js.gz went from 301kb to 720kb with --no-sourcemap. More than double in size. |
I see an increase in my bundle size if I use the --no-sourcemap option as well. |
@naveedahmed1 @grizzm0 @rerickson1 my bad, fix in #3262 |
@filipesilva I tried angular-cli: 1.0.0-beta.21 and with ng build --aot --prod --no-sourcemap I am still getting the total bundles size of 38.4Mb while if I dont use the --no-sourcemap, the size of the generated bundles is 14.3Mb. |
@naveedahmed1 #3262 has been merged but will only be out in the next release. |
Add `--no-sourcemap` option to `ng build/serve/test`. Disabling sourcemaps can help with build speeds. My tests on a medium project shoul a 11.5% improvement on initial builds, and a 37% improvement on rebuilds. Disabling sourcemaps will make debugging harder, since it makes line information very innacurate. Partially address angular#1980
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add
--no-sourcemap
option tong build/serve/test
.Disabling sourcemaps can help with build speeds. My tests on a medium project show a 11.5% improvement on initial builds, and a 37% improvement on rebuilds.
Disabling sourcemaps will make debugging harder, since it makes line information very innacurate.
Partially address #1980