expose ngc i18n options #3098

tdesmet · 2016-11-10T12:47:41Z

This allows you to pass the i18n file, format and locale to ngc from the cli command line

googlebot · 2016-11-10T12:47:43Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

tdesmet · 2016-11-10T12:48:52Z

I signed it!

googlebot · 2016-11-10T12:48:53Z

CLAs look good, thanks!

hansl · 2016-11-10T21:24:10Z

@vicb could you confirm (we can talk about it tomorrow) that this change will work with the next iterations of i18n?

vicb · 2016-11-11T02:56:23Z

tests/e2e/tests/build/aot-i18n.ts

+         </file>
+        </xliff>`))
+    .then(() => appendToFile('src/app/app.component.html',
+      '<h1 i18n="User welcome|An introduction header for this sample">Hello i18n!</h1>'))


remove User welcome| (because meaning should seldom be used)

Ok, I did not know that.

Also couldn't find anything about using it seldom on the angular cookbook.

vicb · 2016-11-11T02:57:31Z

yep let's talk tomorrow.

hansl

Good stuff! Just one comment to add another test and it should be good!

hansl · 2016-11-11T17:56:04Z

tests/e2e/tests/build/aot-i18n.ts

+      '<h1 i18n="An introduction header for this sample">Hello i18n!</h1>'))
+    .then(() => ng('build', '--aot', '--i18n-file', 'src/locale/messages.fr.xlf', '--i18n-format',
+      'xlf', '--locale', 'fr'))
+    .then(() => expectFileToMatch('dist/main.bundle.js', /Bonjour i18n!/));


Could you add a negative test? Running ng build on the same project without --locale should not contain Bonjour i18n.

tdesmet · 2016-11-15T06:26:43Z

@hansl is this ok now?

hansl

Yes, this looks great. LGTM

hansl · 2016-11-18T19:26:53Z

I'll rebase and merge this soon.

shaneog · 2016-11-23T17:17:06Z

Just a little nudge.
I have an application in production using CLI, AoT and i18n and at the moment I have to run a hacky gulp task to make it work. It would be great to get this merged.

Thanks!

shaneog · 2016-12-02T10:53:03Z

@hansl Is there anything we can do to get this PR into the next release?

hansl · 2016-12-02T23:33:31Z

Sorry, not beta 22, but beta 23. I'll rebase this today.

ghost · 2016-12-06T22:57:27Z

Not sure if there's something wrong with the PR, but I've cloned the repo, linked it with "npm link", but when I run it, it is looking for a folder in someone's user directory @tdesmet @hansl ?

$ ng serve --aot --locale zh --i18nFormat xtb --i18nFile ./src/i18n/messages.zh.xtb
** NG Live Development Server is running on http://localhost:4200. **
  0% compilingpath must be a string or Buffer
TypeError: path must be a string or Buffer
    at TypeError (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.fs.readFileSync (fs.js:508:33)
    at Function.CodeGenerator.create (C:\Users\iminar\Dev\angular\modules\@angular\compiler-cli\src\codegen.ts:102:29)
    at AotPlugin._make (C:\Projects\npm\angular-cli\packages\webpack\src\plugin.ts:207:54)

I have no clue why this is happening?

I've also rebased the solution the latest Angular-CLI version which has updated dependencies to Angular Compiler, but same error...:

$ ng serve --aot --locale zh --i18nFormat xtb --i18nFile ./src/i18n/messages.zh.xtb
** NG Live Development Server is running on http://localhost:4200. **
path must be a string or Buffer
TypeError: path must be a string or Buffer
    at TypeError (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.fs.readFileSync (fs.js:508:33)
    at Function.CodeGenerator.create (C:\Projects\npm\angular-cli\node_modules\@angular\compiler-cli\src\codegen.js:83:33)
    at AotPlugin._make (C:\Projects\npm\angular-cli\packages\@ngtools\webpack\src\plugin.ts:229:60)
    at Compiler.<anonymous> (C:\Projects\npm\angular-cli\packages\@ngtools\webpack\src\plugin.ts:190:75)
    at Compiler.applyPluginsParallel (C:\Projects\npm\angular-cli\node_modules\tapable\lib\Tapable.js:193:14)
    at Compiler.<anonymous> (C:\Projects\npm\angular-cli\node_modules\webpack\lib\Compiler.js:463:8)
    at Compiler.applyPluginsAsyncSeries (C:\Projects\npm\angular-cli\node_modules\tapable\lib\Tapable.js:95:46)
    at Compiler.compile (C:\Projects\npm\angular-cli\node_modules\webpack\lib\Compiler.js:456:7)
    at Watching.<anonymous> (C:\Projects\npm\angular-cli\node_modules\webpack\lib\Compiler.js:46:17)
    at next (C:\Projects\npm\angular-cli\node_modules\tapable\lib\Tapable.js:102:11)
    at Compiler.invalidAsyncPlugin (C:\Projects\npm\angular-cli\node_modules\webpack-dev-middleware\middleware.js:119:3)
    at next (C:\Projects\npm\angular-cli\node_modules\tapable\lib\Tapable.js:104:14)
    at Compiler.<anonymous> (C:\Projects\npm\angular-cli\node_modules\webpack\lib\CachePlugin.js:31:4)
    at Compiler.applyPluginsAsyncSeries (C:\Projects\npm\angular-cli\node_modules\tapable\lib\Tapable.js:106:13)
    at Watching._go (C:\Projects\npm\angular-cli\node_modules\webpack\lib\Compiler.js:44:16)
    at Watching.<anonymous> (C:\Projects\npm\angular-cli\node_modules\webpack\lib\Compiler.js:36:8)
    at Compiler.readRecords (C:\Projects\npm\angular-cli\node_modules\webpack\lib\Compiler.js:367:10)
    at new Watching (C:\Projects\npm\angular-cli\node_modules\webpack\lib\Compiler.js:33:16)
    at Compiler.watch (C:\Projects\npm\angular-cli\node_modules\webpack\lib\Compiler.js:204:17)
    at module.exports (C:\Projects\npm\angular-cli\node_modules\webpack-dev-middleware\middleware.js:146:27)
    at new Server (C:\Projects\npm\angular-cli\node_modules\webpack-dev-server\lib\Server.js:43:20)
    at Class.run (C:\Projects\npm\angular-cli\packages\angular-cli\tasks\serve-webpack.ts:85:22)
    at C:\Projects\npm\angular-cli\packages\angular-cli\commands\serve.ts:105:26
    at process._tickCallback (internal/process/next_tick.js:103:7)

tdesmet · 2016-12-07T06:56:48Z

Have you tried putting the path between double quotes?

ng serve --aot --locale zh --i18nFormat xtb --i18nFile "./src/i18n/messages.zh.xtb"

ghost · 2016-12-07T08:12:37Z

Nope, same problem :( @tdesmet

$ ng serve --aot --locale zh --i18nFormat xtb --i18nFile "./src/i18n/messages.zh.xtb"
** NG Live Development Server is running on http://localhost:4200. **
  0% compilingpath must be a string or Buffer
TypeError: path must be a string or Buffer
    at TypeError (native)
    at Object.fs.openSync (fs.js:640:18)
    at Object.fs.readFileSync (fs.js:508:33)
    at Function.CodeGenerator.create (C:\Users\iminar\Dev\angular\modules\@angular\compiler-cli\src\codegen.ts:102:29)

filipesilva · 2016-12-08T13:46:52Z

@rolandoldengarm that's probably a typescript problem, yesterday a few of those were cropping up. Make sure you are using 2.0.x and NOT 2.1.x.

filipesilva · 2016-12-08T13:48:53Z

@tdesmet some recent changes introduced a lot of conflicts with this PR, can you rebase and fix them?

tdesmet · 2016-12-09T08:26:13Z

Done

ghost · 2016-12-12T02:35:02Z

@filipesilva I've tried on a clean machine, with TS 2.0.10, and still the same error.
I've cloned repo, used "npm link" to link it, then "npm link angular-cli" in my project.

ghost · 2016-12-13T01:59:48Z

sorry for bothering you again, but when will this PR be merged and released? We are blocked by this; I don't know how to implement i18n + AOT without this PR being merged.

tdesmet · 2016-12-14T08:42:09Z

@hansl @filipesilva can you guys merge this please?

nileshmali · 2016-12-14T09:21:54Z

packages/angular-cli/commands/build.ts.orig

+  supressSizes: boolean;
+  baseHref?: string;
+  aot?: boolean;
+<<<<<<< HEAD


Git merge issue?
There are many more below as well.

Woops, I'm sorry these .orig files should never have been committed.

These are artifacts from merging and shouldn't have been added I'm used to them being ignored.

Anyway I Removed them and everything should be good.

ghidoz · 2016-12-14T17:26:55Z

Hi guys, thanks for the good work! Do you know when it will be merged and released? Are there any chances for the next week? Thanks!

hansl · 2016-12-14T20:06:36Z

Alright. Merging this. I am about to change the plugin for the next release and this LGTM, so expect it to come in the next release (which will also be ng 2.3 compatible).

hansl · 2016-12-14T20:08:07Z

@tdesmet could we also have an angular-cli global option for these? would that be useful?

tdesmet · 2016-12-14T20:18:06Z

@hansl what do you mean?

hansl · 2016-12-14T21:08:18Z

Would it make sense to have i18file and i18format (and potentially locale as well?) in the angular-cli.json configuration for your app rather than having both on the command line?

Basically are those flags likely to change between two calls of ng build? I would think locale does, but i18file and format would not?

tdesmet · 2016-12-14T21:25:18Z

Format stays the same but locale and file do not in this implementation. File is translated messages for the locale. So if locale is fr then file is messages.fr.xlf anf if locale is de then file is messages.de.xlf.

I'm thinking we could probably make this easier by determining the file name by the given locale. Bu this would be less flexible as all users need to follow the same naming pattern.

Currently in my app I have a locales directory and each locale is a subdirectory containing a messages.locale.xlf file. My build process scans the locales directory and executes the build command for each found subdirectory.
By typing this I realise I could just name all xlf files the same since they all live in seperate directories.

For me it would be great if we could implement something similar in the cli. But not sure if this workflow would work for others...

hansl · 2016-12-14T21:32:44Z

Having a CLI specific workflow is okay with me, as long as it’s easy and transparent to the user. Let’s discuss more about this in a separate issue; it’s probably not something coming to CLI final but I’m definitely interested in making it easy for users to translate their apps in the future! For now, having a broken workflow is probably good enough. Thanks again for the PR!

…

-- Hans Larsen On December 14, 2016 at 1:25:20 PM, Tom De Smet ([email protected]) wrote: Format stays the same but locale and file do not in this implementation. File is translated messages for the locale. So if locale is fr then file is messages.fr.xlf anf if locale is de then file is messages.de.xlf. I'm thinking we could probably make this easier by determining the file name by the given locale. Bu this would be less flexible as all users need to follow the same naming pattern. Currently in my app I have a locales directory and each locale is a subdirectory containing a messages.locale.xlf file. My build process scans the locales directory and executes the build command for each found subdirectory. By typing this I realise I could just name all xlf files the same since they all live in seperate directories. For me it would be great if we could implement something similar in the cli. But not sure if this workflow would work for others... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3098 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AApn8RIRM0vPJITmGS4fzUNhjTcRUZvrks5rIF6_gaJpZM4Kun4-> .

Also available on the webpack plugin.

angular-automatic-lock-bot · 2019-09-11T17:43:00Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

tdesmet added 2 commits November 10, 2016 10:26

Expose ngc i18n options

ef62e6a

Add e2e test for i18n support

ee821ff

googlebot added the cla: no label Nov 10, 2016

googlebot added cla: yes and removed cla: no labels Nov 10, 2016

Fix tslint errors

0b4b621

vicb reviewed Nov 11, 2016

View reviewed changes

Remove meaning

5d4bfe0

hansl suggested changes Nov 11, 2016

View reviewed changes

Add negative test

935787a

tdesmet mentioned this pull request Nov 18, 2016

[Discussion] angular-cli and i18n (ng-xi18n + ngc) #2201

Closed

shaneog mentioned this pull request Nov 18, 2016

Add possibility to pass i18n options to Webpack Aot Plugin #3047

Closed

hansl approved these changes Nov 18, 2016

View reviewed changes

hansl added the pr_action: merge label Nov 18, 2016

filipesilva added the state: WIP label Dec 8, 2016

filipesilva removed the pr_action: merge label Dec 8, 2016

Merge remote-tracking branch 'upstream/master' into i18n-options

b3b6707

Merge branch 'master' into i18n-options

5b45739

nileshmali reviewed Dec 14, 2016

View reviewed changes

Remove .orig artifacts from kdiff3

33be929

hansl merged commit 2a0a42d into angular:master Dec 14, 2016

CanKattwinkel mentioned this pull request Dec 19, 2016

i18n: Anuglar 2 localization w11k/calendar-for-trello#84

Closed

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017

feat(i18n): add i18n command line options (angular#3098)

37f0028

Also available on the webpack plugin.

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expose ngc i18n options #3098

expose ngc i18n options #3098

tdesmet commented Nov 10, 2016

googlebot commented Nov 10, 2016

tdesmet commented Nov 10, 2016

googlebot commented Nov 10, 2016

hansl commented Nov 10, 2016

vicb Nov 11, 2016

tdesmet Nov 11, 2016

vicb commented Nov 11, 2016

hansl left a comment

hansl Nov 11, 2016

tdesmet commented Nov 15, 2016

hansl left a comment

hansl commented Nov 18, 2016

shaneog commented Nov 23, 2016

shaneog commented Dec 2, 2016

hansl commented Dec 2, 2016

ghost commented Dec 6, 2016 •

edited by ghost

Loading

tdesmet commented Dec 7, 2016

ghost commented Dec 7, 2016

filipesilva commented Dec 8, 2016

filipesilva commented Dec 8, 2016

tdesmet commented Dec 9, 2016

ghost commented Dec 12, 2016

ghost commented Dec 13, 2016

tdesmet commented Dec 14, 2016

nileshmali Dec 14, 2016 •

edited

Loading

tdesmet Dec 14, 2016

ghidoz commented Dec 14, 2016

hansl commented Dec 14, 2016

hansl commented Dec 14, 2016

tdesmet commented Dec 14, 2016

hansl commented Dec 14, 2016

tdesmet commented Dec 14, 2016

hansl commented Dec 14, 2016 via email

angular-automatic-lock-bot bot commented Sep 11, 2019

expose ngc i18n options #3098

expose ngc i18n options #3098

Conversation

tdesmet commented Nov 10, 2016

googlebot commented Nov 10, 2016

tdesmet commented Nov 10, 2016

googlebot commented Nov 10, 2016

hansl commented Nov 10, 2016

vicb Nov 11, 2016

Choose a reason for hiding this comment

tdesmet Nov 11, 2016

Choose a reason for hiding this comment

vicb commented Nov 11, 2016

hansl left a comment

Choose a reason for hiding this comment

hansl Nov 11, 2016

Choose a reason for hiding this comment

tdesmet commented Nov 15, 2016

hansl left a comment

Choose a reason for hiding this comment

hansl commented Nov 18, 2016

shaneog commented Nov 23, 2016

shaneog commented Dec 2, 2016

hansl commented Dec 2, 2016

ghost commented Dec 6, 2016 • edited by ghost Loading

tdesmet commented Dec 7, 2016

ghost commented Dec 7, 2016

filipesilva commented Dec 8, 2016

filipesilva commented Dec 8, 2016

tdesmet commented Dec 9, 2016

ghost commented Dec 12, 2016

ghost commented Dec 13, 2016

tdesmet commented Dec 14, 2016

nileshmali Dec 14, 2016 • edited Loading

Choose a reason for hiding this comment

tdesmet Dec 14, 2016

Choose a reason for hiding this comment

ghidoz commented Dec 14, 2016

hansl commented Dec 14, 2016

hansl commented Dec 14, 2016

tdesmet commented Dec 14, 2016

hansl commented Dec 14, 2016

tdesmet commented Dec 14, 2016

hansl commented Dec 14, 2016 via email

angular-automatic-lock-bot bot commented Sep 11, 2019

ghost commented Dec 6, 2016 •

edited by ghost

Loading

nileshmali Dec 14, 2016 •

edited

Loading