Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for the ssl options of the ng serve task #2792

Merged
merged 1 commit into from
Oct 20, 2016
Merged

add support for the ssl options of the ng serve task #2792

merged 1 commit into from
Oct 20, 2016

Conversation

sbaramov
Copy link
Contributor

Added support for running the webpack dev server in ssl mode through 'ng serve' command. The command options --ssl, --ssl-key, and --ssl-cert are used to configure the server.

This is a second attempt to submit the pull request because the first one #2089 has a broken CLA. This fixes issue #1576

@sbaramov
Copy link
Contributor Author

@Brocco this is the second pull request with correct CLA. I could not run locally npm run e2e because of this error:

The package [email protected] does not satisfy its siblings' peerDependencies requirements!

This appear to be a local env issue which i will investigate later. Hope this works for you.

@Brocco Brocco merged commit ba414ab into angular:master Oct 20, 2016
@Brocco
Copy link
Contributor

Brocco commented Oct 20, 2016

Thanks for moving this to a new PR, merged!

kieronqtran pushed a commit to kieronqtran/angular-cli that referenced this pull request Oct 21, 2016
Splaktar pushed a commit to DevIntent/angular-cli that referenced this pull request Oct 22, 2016
@ranbuch
Copy link

ranbuch commented Dec 8, 2016

I'm running ng serve options --ssl and I'm getting your connection is not private no unsafe option page. Usually when I'm getting this error message I can press on the Advanced button and click Proceed to localgost (unsafe) but not in that case.

Chrome error: NET::ERR_CERT_INVALID

You cannot visit localhost right now because the website sent scrambled credentials that Google Chrome cannot process. Network errors and attacks are usually temporary, so this page will probably work later

Is there anyone else who's having the same problem?

@davidbilge
Copy link

davidbilge commented Dec 8, 2016

Hi ranbuch, I had the same problem a while ago. You can use chrome://flags/#allow-insecure-localhost to allow insecure ssl certificates for localhost which is very useful on a dev machine.

@ranbuch
Copy link

ranbuch commented Dec 8, 2016

Thank you davidbilge,

I haven't found a useful flag in chrome://flags.

The only flag that I thought would help is:

Allow invalid certificates for resources loaded from localhost

It's on Enabled

I'm running Chrome Version 55.0.2883.75 m on Windows 10.

@ranbuch
Copy link

ranbuch commented Dec 8, 2016

Oh, I should have re-lunch chrome.

It's winking for me now.

Thanks!

@davidbilge
Copy link

Okay, great :)

@sumigoma
Copy link

@ranbuch @davidbilge what you're seeing is probably related to #3645

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants