Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept git remote as an option for github pages deploy #2786

Closed
craigmichaelmartin opened this issue Oct 19, 2016 · 3 comments
Closed

accept git remote as an option for github pages deploy #2786

craigmichaelmartin opened this issue Oct 19, 2016 · 3 comments
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@craigmichaelmartin
Copy link

Feature request: accepting a git remote name as an option for github pages deploy. If acceptable, I would be happy to implement.

Use cases

  • Devs who use a different upstream remote name than origin.
  • Devs who wish to deploy to their fork as part of a review step.

Workarounds

  • git remote rename

Alternatives

  • If not acceptable, I'd be happy to submit a PR to add a note to the README and/or the output message when there is no remote found for origin.
@filipesilva
Copy link
Contributor

I'm happy to review a PR for this enhancement, but would like to mention that we're likely reworking the github deploy functionality to use the docs folder as mentioned in https://github.com/blog/2228-simpler-github-pages-publishing.

@filipesilva filipesilva added type: enhancement P5 The team acknowledges the request but does not plan to address it, it remains open for discussion labels Oct 23, 2016
@filipesilva
Copy link
Contributor

Closed via #4385.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Development

No branches or pull requests

2 participants