Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(test): Logs errors in module loading in ng2's test.ts #2785

Conversation

renehamburger
Copy link

Fixes #2640

@filipesilva, if you run ng test in https://github.com/renehamburger/angular-cli-issue/commits/master at HEAD and HEAD^ you'll be able to see the difference the logging of the exception makes.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@renehamburger
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@renehamburger renehamburger force-pushed the issue2640-test-ts-error-handling branch from 943839a to a4d52be Compare October 20, 2016 20:33
@filipesilva
Copy link
Contributor

Got it! I reproed and saw how your changes help. We'll merge it in soon, thanks!

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silent errors in test.ts
4 participants