fix(generate): show error when no name is specified #2684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show custom error when user forgets the name while generating blueprints. Earlier it would fall to the dynamicPathParser function and throw a TypeError: Path must be a string. Received undefined.
Brocco
pushed a commit
that referenced
this pull request
Oct 19, 2016
Show custom error when user forgets the name while generating blueprints. Earlier it would fall to the dynamicPathParser function and throw a TypeError: Path must be a string. Received undefined. Close #2684
kieronqtran
pushed a commit
to kieronqtran/angular-cli
that referenced
this pull request
Oct 21, 2016
Show custom error when user forgets the name while generating blueprints. Earlier it would fall to the dynamicPathParser function and throw a TypeError: Path must be a string. Received undefined. Close angular#2684
texel
pushed a commit
to splice/angular-cli
that referenced
this pull request
Nov 3, 2016
Show custom error when user forgets the name while generating blueprints. Earlier it would fall to the dynamicPathParser function and throw a TypeError: Path must be a string. Received undefined. Close angular#2684
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show custom error when user forgets the name while generating blueprints.
Earlier it would fall to the dynamicPathParser function and throw a TypeError: Path must be a string. Received undefined.
I think it wouldn't make sense to add the same test to all the
generate-*.spec.jsfiles, but not sure ifgenerate-module.spec.jsis the best place either.