Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No any error output when used ng serve --aot in project which has errors #2667

Closed
vadjs opened this issue Oct 12, 2016 · 31 comments
Closed

No any error output when used ng serve --aot in project which has errors #2667

vadjs opened this issue Oct 12, 2016 · 31 comments
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@vadjs
Copy link

vadjs commented Oct 12, 2016

Please provide us with the following information:

No any error output when used ng serve --aot in project which has errors(compilation fails).

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Linux(Ubuntu 16.04)

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

angular-cli: local (v1.0.0-beta.17, branch: master)
node: 6.7.0
os: linux x64

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

The log given by the failure.

Normally this include a stack trace and some more information.

I getting this log with "infinite building":
ng serve --aot Could not start watchman; falling back to NodeWatcher for file system events. Visit http://ember-cli.com/user-guide/#watchman for more info. ** NG Live Development Server is running on http://localhost:4200. ** 23% building modules 109/109 modules 0 active
But nothing of errors.

Mention any other details that might be useful.

With normal ng-serve project successfully builds but has intentional error which appears in browser console - not imported "angular2-text-mask" package(but it's functionality used in template).

Thanks! We'll be in touch soon.

@filipesilva
Copy link
Contributor

Does it repeatedly rebuild as well, is that it?

@filipesilva filipesilva added type: bug/fix command: build P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Oct 14, 2016
@vadjs
Copy link
Author

vadjs commented Oct 17, 2016

No, it's just keep in this state permanently. No any rebuild.

@Simon-Briggs
Copy link

I faced this as well.

ng serve --aot simply hangs at 20%.

ng build --aot showed me the problem.

AppModule is not an NgModule
Error: AppModule is not an NgModule

@inska
Copy link

inska commented Oct 25, 2016

same here

AppModule is not an NgModule
Error: AppModule is not an NgModule

@Meligy
Copy link
Contributor

Meligy commented Oct 31, 2016

Same here with beta.19-3.

Both outputs from serve --aot and build --aot happening to me.

For serve --aot, if I navigate to http://localhost:4200 while it's waiting, it adds this new line to the terminal console (not the browser console, the browser just times out after a while):

webpack: wait until bundle finished: /

P.S.

Exact ng serve --aot message:

** NG Live Development Server is running on http://localhost:4200. **
 20% building modules 85/85 modules 0 active
webpack: wait until bundle finished: /
webpack: wait until bundle finished: /

As mentioned above the webpack lines are only when I try to browse to the site.

Exact build -prod --aot message:

Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
 10% building modules 5/6 modules 1 active ...eligy/routing-angular-cli/src/main.tsError: AppModule is not an NgModule
    at AotPlugin.getNgModuleMetadata (/Users/Meligy/Code/github/Meligy/routing-angular-cli/node_modules/angular-cli/node_modules/@ngtools/webpack/src/plugin.js:247:19)
    at AotPlugin._processNgModule (/Users/Meligy/Code/github/Meligy/routing-angular-cli/node_modules/angular-cli/node_modules/@ngtools/webpack/src/plugin.js:230:42)
    at /Users/Meligy/Code/github/Meligy/routing-angular-cli/node_modules/angular-cli/node_modules/@ngtools/webpack/src/plugin.js:206:23
 10% building modules 6/6 modules 0 activeAppModule is not an NgModule
Error: AppModule is not an NgModule
    at AotPlugin.getNgModuleMetadata (/Users/Meligy/Code/github/Meligy/routing-angular-cli/node_modules/angular-cli/node_modules/@ngtools/webpack/src/plugin.js:247:19)
    at AotPlugin._processNgModule (/Users/Meligy/Code/github/Meligy/routing-angular-cli/node_modules/angular-cli/node_modules/@ngtools/webpack/src/plugin.js:230:42)
    at /Users/Meligy/Code/github/Meligy/routing-angular-cli/node_modules/angular-cli/node_modules/@ngtools/webpack/src/plugin.js:206:23

The message AppModule is not an NgModule in the line 10% building modules 6/6 modules 0 activeAppModule is not an NgModule is shown in red while the rest of the message is shown in normal black color.

@Meligy
Copy link
Contributor

Meligy commented Oct 31, 2016

I have upgraded my test repo to beta.19-3 if this helps with testing:

https://github.com/meligy/routing-angular-cli

@erycson
Copy link

erycson commented Nov 1, 2016

same here

@masterfix
Copy link

Same problem here. Not with the AppModule but with another module.

@montella1507
Copy link

Same here.

@irvjc82
Copy link

irvjc82 commented Nov 9, 2016

Same problem here

10% building modules 2/2 modules 0 activeError: AppModule is not an NgModule
    at AotPlugin.getNgModuleMetadata (C:\Users\Irvin\WebstormProjects\nexus4_angular_cli\node_modules\@ngtools\webpack\src\plugin.js:247:19)
    at AotPlugin._processNgModule (C:\Users\Irvin\WebstormProjects\nexus4_angular_cli\node_modules\@ngtools\webpack\src\plugin.js:230:42)
    at C:\Users\Irvin\WebstormProjects\nexus4_angular_cli\node_modules\@ngtools\webpack\src\plugin.js:206:23
    at process._tickCallback (internal/process/next_tick.js:103:7)
AppModule is not an NgModule
Error: AppModule is not an NgModule
    at AotPlugin.getNgModuleMetadata (C:\Users\Irvin\WebstormProjects\nexus4_angular_cli\node_modules\@ngtools\webpack\src\plugin.js:247:19)
    at AotPlugin._processNgModule (C:\Users\Irvin\WebstormProjects\nexus4_angular_cli\node_modules\@ngtools\webpack\src\plugin.js:230:42)
    at C:\Users\Irvin\WebstormProjects\nexus4_angular_cli\node_modules\@ngtools\webpack\src\plugin.js:206:23
    at process._tickCallback (internal/process/next_tick.js:103:7)

@unsafecode
Copy link

+1 Have the same issue with @ngtools/webpack and a lazy route

@ajantsch
Copy link

+1 what @unsafecode said, same problem with @ngtools/webpack and a lazy route.

@riparrag
Copy link

same here
activeError: AppModule is not an NgModule

@Judahh
Copy link

Judahh commented Nov 11, 2016

Same here

@mallim
Copy link

mallim commented Nov 13, 2016

angular-cli: 1.0.0-beta.19-3
node: 6.9.1
os: win32 x64

Error: LazyLoadedModule is not an NgModule
    at AotPlugin.getNgModuleMetadata (root_folder\node_modules\@ngtools\webpack\src\plugin.js:247:19)
    at AotPlugin._processNgModule (root_folder\node_modules\@ngtools\webpack\src\plugin.js:230:42)
    at AotPlugin._processNgModule (root_folder\node_modules\@ngtools\webpack\src\plugin.js:239:33)
    at root_folder\node_modules\@ngtools\webpack\src\plugin.js:206:23

In app.routing.ts:

      {
        path: 'lazy_loaded',
        loadChildren: 'app/lazy_loaded/lazy_loaded.module#LazyLoadedModule'
      }

@indooorsman
Copy link

indooorsman commented Nov 16, 2016

+1
and looks like the compiler-cli does not get the correct annotations of my app.module.ts

getNgModuleMetadata of StaticSymbol {
  filePath: '/Users/indooorsman/workspace/projects/web/yingke/server/ykly-toc-web/src/main/webapp/spa_src/src/app/app.module.ts',
  name: 'AppModule',
  members: undefined }
get annotations: []
Error: AppModule is not an NgModule
    at AotPlugin.getNgModuleMetadata (/Users/indooorsman/workspace/projects/web/yingke/server/ykly-toc-web/src/main/webapp/spa_src/node_modules/@ngtools/webpack/src/plugin.js:249:19)
    at AotPlugin._processNgModule (/Users/indooorsman/workspace/projects/web/yingke/server/ykly-toc-web/src/main/webapp/spa_src/node_modules/@ngtools/webpack/src/plugin.js:230:42)

@ovrmrw
Copy link

ovrmrw commented Nov 19, 2016

same here "angular-cli": "1.0.0-beta.19-3"

** NG Live Development Server is running on http://localhost:4200. **
 10% building modules 2/2 modules 0 active(node:1276) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: AppModule is not an NgModule
 20% building modules 84/84 modules 0 active

@ctrl-brk
Copy link

Still in beta.20-4

@dmittendorf
Copy link

Same problem with 1.0.0-beta.21

@d668
Copy link

d668 commented Dec 6, 2016

same thing here, seems like caused by this issue

ng serve just freezes

@arlowhite
Copy link

arlowhite commented Dec 13, 2016

I have this problem with angular-cli: 1.0.0-beta.22-1
Same code worked fine with version 1.0.0-beta.19-3

EDIT: From comments on #3157
I was over-eager and set typescript to 2.1.4. Downgrading TypeScript to 2.0.10 avoids the AppModule is not an NgModule error.

@aaronleestic
Copy link

My ng serve hanging went away after I updated /src/tsconfig.json to the one generated by beta.22

@d668
Copy link

d668 commented Dec 14, 2016

the way i deal with it is I run ng build and see where is the error in the code actually

@frank-mendez
Copy link

+1 20% building modules 84/84 modules 0 activewebpack: wait until bundle finished:
What is the possible solution for this?

@arlowhite
Copy link

From what I've seen here and on #3157 and #3426

Most problems seem to be caused by people jumping ahead to a newer version of Angular or TypeScript.

Double-check package.json
For an angular-cli 1.0.0-beta.22-1 project, you should be on:

  • Angular 2.2.3 (@angular/* packages)
  • Don't forget "@angular/compiler-cli": "2.2.3" (under devDependencies)
  • @angular/router 3.2.3
  • typescript 2.0.10 (default version is ~2.0.3)

You should use ng init --skip-npm to diff your package.json with the default. Or create a fresh project somewhere else ng new --skip-npm fresh-ng-project and use your favorite diff tool to compare your package.json with the default.

After you've double-checked your package.json, npm install

If that doesn't fix it, some people have said changes they made to tsconfig.json caused the problem. So review that diff as well.

Otherwise, review how your module is exported. In my project, one module was
export default class MyModule {}
export default no longer works.

Remove default, if this is a lazy-loaded module in the router, you will need to add #MyModule
loadChildren: 'app/path/to/my.module#MyModule'

@meghadureja
Copy link

getting below error while running ng build command.

No errors
Error: No errors

at validate (/home/meghad/testingWorkspace/web/node_modules/extract-text-webpack-plugin/schema/validator.js:10:9)
at Function.ExtractTextPlugin.extract (/home/meghad/testingWorkspace/web/node_modules/extract-text-webpack-plugin/index.js:188:3)
at /home/meghad/testingWorkspace/web/node_modules/angular-cli/models/webpack-build-utils.js:72:77
at Array.map (native)
at Object.makeCssLoaders (/home/meghad/testingWorkspace/web/node_modules/angular-cli/models/webpack-build-utils.js:69:53)
at Object.getWebpackCommonConfig (/home/meghad/testingWorkspace/web/node_modules/angular-cli/models/webpack-build-common.js:77:65)
at new NgCliWebpackConfig (/home/meghad/testingWorkspace/web/node_modules/angular-cli/models/webpack-config.js:22:49)
at Class.exports.default.Task.extend.run (/home/meghad/testingWorkspace/web/node_modules/angular-cli/tasks/build-webpack.js:18:22)
at Class.Command.extend.run (/home/meghad/testingWorkspace/web/node_modules/angular-cli/commands/build.js:60:26)
at Class. (/home/meghad/testingWorkspace/web/node_modules/angular-cli/ember-cli/lib/models/command.js:152:17)
at tryCatch (/home/meghad/testingWorkspace/web/node_modules/es6-promise/dist/es6-promise.js:410:12)
at invokeCallback (/home/meghad/testingWorkspace/web/node_modules/es6-promise/dist/es6-promise.js:425:13)
at /home/meghad/testingWorkspace/web/node_modules/es6-promise/dist/es6-promise.js:172:16
at flush (/home/meghad/testingWorkspace/web/node_modules/es6-promise/dist/es6-promise.js:121:5)
at nextTickCallbackWith0Args (node.js:419:9)
at process._tickCallback (node.js:348:13)

@iamgmd
Copy link

iamgmd commented Jan 28, 2017

getting same as meghadureja on ng build or ng serve

happens on windows and mac with prompts in administrator mode.

node: 6.9.4
npm: 3.10.10
angular-cli: 1.0.0-beta.26
angular: 2.4.5
router: 3.4.5

@equinox
Copy link
Contributor

equinox commented Jan 28, 2017

@iamgmd

Hi there, you're after #4264 for the current issue, with a working workaround in that thread.

@iamgmd
Copy link

iamgmd commented Jan 28, 2017

@equinox

Thanks, just seen that after I posted. Thanks for redirect.

@hansl
Copy link
Contributor

hansl commented Feb 3, 2017

Closing this as fixed.

@hansl hansl closed this as completed Feb 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Development

No branches or pull requests