Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) ng complete: Suggest different way to capture output to .bashrc/.zshrc #2635

Conversation

catull
Copy link
Contributor

@catull catull commented Oct 10, 2016

At long last, the output of ng completion can all be fed to your favourite shell startup file.
The discussion took place in issue #2253, the reasoning behind this PR is at #2253 (comment).

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the readme to reflect this?

Copy link
Contributor Author

@catull catull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, the fix MUST not be hidden in the script file; only a handful of people know where to look. Will document the suggested fix in README.md.

…fix-suggest-different-shell-output-redirection' of github.com:catull/angular-cli into fix-suggest-different-shell-output-redirection
@catull
Copy link
Contributor Author

catull commented Oct 10, 2016

Complied with the review finding.

@catull catull deleted the fix-suggest-different-shell-output-redirection branch October 10, 2016 22:56
JJayet pushed a commit to JJayet/angular-cli that referenced this pull request Oct 14, 2016
Brocco pushed a commit that referenced this pull request Oct 19, 2016
texel pushed a commit to splice/angular-cli that referenced this pull request Nov 3, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants