-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) ng complete
: Suggest different way to capture output to .bashrc/.zshrc
#2635
(fix) ng complete
: Suggest different way to capture output to .bashrc/.zshrc
#2635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the readme to reflect this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, the fix MUST not be hidden in the script file; only a handful of people know where to look. Will document the suggested fix in README.md.
…fix-suggest-different-shell-output-redirection' of github.com:catull/angular-cli into fix-suggest-different-shell-output-redirection
Complied with the review finding. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
At long last, the output of
ng completion
can all be fed to your favourite shell startup file.The discussion took place in issue #2253, the reasoning behind this PR is at #2253 (comment).