Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(karma): Add cli config poll option to karma default config #2486

Merged
merged 1 commit into from
Oct 10, 2016

Conversation

JSMike
Copy link
Contributor

@JSMike JSMike commented Oct 3, 2016

With #1814 the defaults.poll property was added to angular-cli.json. This configuration setting is currently applies to ng serve but not ng test. This fix adds the poll value to the karma defaults so that if you set defaults: { poll: 1000 } it will apply to both ng serve and ng test.

@JSMike JSMike force-pushed the karmaDefaultsUpdate branch 2 times, most recently from e19cab6 to b09619a Compare October 5, 2016 22:52
@JSMike JSMike changed the title fix (karma): Add cli config poll option to karma default config fix(karma): Add cli config poll option to karma default config Oct 5, 2016
@JSMike JSMike force-pushed the karmaDefaultsUpdate branch 3 times, most recently from 6218ae5 to 653ea36 Compare October 6, 2016 18:46
@JSMike
Copy link
Contributor Author

JSMike commented Oct 6, 2016

I still need to do some more testing, but this appears to be working as intended now. Initially I wasn't requiring in the config correctly.

@filipesilva
Copy link
Contributor

@JSMike is it fully working in your scenario?

With angular#1814 the `defaults.poll` property was added to angular-cli.json. This configuration setting currently applies to `ng serve` but not `ng test`. This fix adds the poll value to the karma defaults so that if you set `defaults: { poll: 1000 }` it will apply to both `ng serve` and `ng test`.
@JSMike JSMike force-pushed the karmaDefaultsUpdate branch from 653ea36 to 1555387 Compare October 10, 2016 04:07
@JSMike
Copy link
Contributor Author

JSMike commented Oct 10, 2016

@filipesilva I'm working on an example to set up the scenario and test it. I'll post tomorrow.

@JSMike
Copy link
Contributor Author

JSMike commented Oct 10, 2016

@filipesilva Confirmed.

I tested in this env: https://github.com/JSMike/angular-cli-docker-test-env
This uses the current PR commit as the global and local angular-cli inside a docker container with a fresh project. The only modifications from a fresh project are the "poll": 1000 in angular-cli.json and setting up karma.conf.js to use a phantomjs webdriver that's hosted in a separate docker container.

When making changes to app.component.ts from the host system the docker container ran tests after a short delay.

@filipesilva filipesilva merged commit 63023ae into angular:master Oct 10, 2016
JJayet pushed a commit to JJayet/angular-cli that referenced this pull request Oct 14, 2016
…ar#2486)

With angular#1814 the `defaults.poll` property was added to angular-cli.json. This configuration setting currently applies to `ng serve` but not `ng test`. This fix adds the poll value to the karma defaults so that if you set `defaults: { poll: 1000 }` it will apply to both `ng serve` and `ng test`.
Brocco pushed a commit that referenced this pull request Oct 19, 2016
With #1814 the `defaults.poll` property was added to angular-cli.json. This configuration setting currently applies to `ng serve` but not `ng test`. This fix adds the poll value to the karma defaults so that if you set `defaults: { poll: 1000 }` it will apply to both `ng serve` and `ng test`.
texel pushed a commit to splice/angular-cli that referenced this pull request Nov 3, 2016
…ar#2486)

With angular#1814 the `defaults.poll` property was added to angular-cli.json. This configuration setting currently applies to `ng serve` but not `ng test`. This fix adds the poll value to the karma defaults so that if you set `defaults: { poll: 1000 }` it will apply to both `ng serve` and `ng test`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants