-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(karma): Add cli config poll option to karma default config #2486
Conversation
e19cab6
to
b09619a
Compare
6218ae5
to
653ea36
Compare
I still need to do some more testing, but this appears to be working as intended now. Initially I wasn't requiring in the config correctly. |
@JSMike is it fully working in your scenario? |
With angular#1814 the `defaults.poll` property was added to angular-cli.json. This configuration setting currently applies to `ng serve` but not `ng test`. This fix adds the poll value to the karma defaults so that if you set `defaults: { poll: 1000 }` it will apply to both `ng serve` and `ng test`.
653ea36
to
1555387
Compare
@filipesilva I'm working on an example to set up the scenario and test it. I'll post tomorrow. |
@filipesilva Confirmed. I tested in this env: https://github.com/JSMike/angular-cli-docker-test-env When making changes to app.component.ts from the host system the docker container ran tests after a short delay. |
…ar#2486) With angular#1814 the `defaults.poll` property was added to angular-cli.json. This configuration setting currently applies to `ng serve` but not `ng test`. This fix adds the poll value to the karma defaults so that if you set `defaults: { poll: 1000 }` it will apply to both `ng serve` and `ng test`.
With #1814 the `defaults.poll` property was added to angular-cli.json. This configuration setting currently applies to `ng serve` but not `ng test`. This fix adds the poll value to the karma defaults so that if you set `defaults: { poll: 1000 }` it will apply to both `ng serve` and `ng test`.
…ar#2486) With angular#1814 the `defaults.poll` property was added to angular-cli.json. This configuration setting currently applies to `ng serve` but not `ng test`. This fix adds the poll value to the karma defaults so that if you set `defaults: { poll: 1000 }` it will apply to both `ng serve` and `ng test`.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
With #1814 the
defaults.poll
property was added to angular-cli.json. This configuration setting is currently applies tong serve
but notng test
. This fix adds the poll value to the karma defaults so that if you setdefaults: { poll: 1000 }
it will apply to bothng serve
andng test
.