Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 5 & false circular dependency warning on .graphql custom compile step #19466

Closed
1 of 15 tasks
qortex opened this issue Nov 23, 2020 · 2 comments
Closed
1 of 15 tasks

Comments

@qortex
Copy link

qortex commented Nov 23, 2020

🐞 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • extract-i18n
  • run
  • config
  • help
  • version
  • doc

Is this a regression?

Yes, my custom build step works flawlessly in Angular v10.

Description

I just switched to Webpack 5 (Angular 11) and I now get 1 warning per .graphql file:

Warning: Circular dependency detected:
src/app/backbone/identity/person.graphql -> src/app/backbone/identity/person.graphql

Nothing fancy with my setup I think, just this webpack extra config:

module.exports = {
  module: {
    rules: [
      {
        test: /\.(graphql|gql)$/,
        exclude: /node_modules/,
        loader: 'graphql-tag/loader',
      },
    ],
  },
};

My graphql files don't import themselves or other files. Just simple graphql queries & mutations.

The warnings are there, but the app works well nonetheless.

Cross-posted here: apollographql/graphql-tag#326

🌍 Your Environment


     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 11.0.2
Node: 14.4.0
OS: linux x64

Angular: 11.0.2
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1100.2
@angular-devkit/build-angular   0.1100.2
@angular-devkit/core            11.0.2
@angular-devkit/schematics      11.0.2
@angular/cdk                    11.0.0
@angular/flex-layout            11.0.0-beta.33
@angular/material               11.0.0
@schematics/angular             11.0.2
@schematics/update              0.1100.2
rxjs                            6.6.3
typescript                      4.0.5
webpack                         5.6.0
@alan-agius4
Copy link
Collaborator

Hi @qortex,

Thanks for opening the issue.

Please be advised that while we do not disallow extending and customizing the Webpack configurations these are not supported by the Angular tooling team.

This is also unlikely to be caused by the Angular CLI as we don't have any handling of graphql files. Please feel free to re-open the issue if you discover otherwise.

Thanks.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants