Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referenced projects must have the new composite setting enabled #18625

Closed
2 tasks done
vbraun opened this issue Aug 26, 2020 · 2 comments
Closed
2 tasks done

Referenced projects must have the new composite setting enabled #18625

vbraun opened this issue Aug 26, 2020 · 2 comments

Comments

@vbraun
Copy link

vbraun commented Aug 26, 2020

Command (mark with an x)

  • new
  • generate

Description

The typescript docs say (https://www.typescriptlang.org/docs/handbook/project-references.html):

Referenced projects must have the new composite setting enabled.

and the solutions-style project generated by angular-cli does not have the composite setting enabled.

The documentation might be wrong, idk, but must is pretty unambiguous. It seems that tsc does compile, but it might have other impacts (performance, ide features not working, just guessing at that point)

🔬 Minimal Reproduction

npx ng new superduper
cd superduper
npx ng generate library foo
egrep -r composite *json projects/foo/*json

🌍 Your Environment


$ npx ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 10.0.7
Node: 12.18.3
OS: linux x64

Angular: 10.0.12
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.1000.7
@angular-devkit/build-angular      0.1000.7
@angular-devkit/build-ng-packagr   0.1000.7
@angular-devkit/core               10.0.7
@angular-devkit/schematics         10.0.7 (cli-only)
@angular/cli                       10.0.7
@schematics/angular                10.0.7 (cli-only)
@schematics/update                 0.1000.7 (cli-only)
ng-packagr                         10.0.4
rxjs                               6.5.5
typescript                         3.9.7
@alan-agius4
Copy link
Collaborator

Hi @vbraun,

The composite compiler option is not needed for solution style tsconfig, it is needed when you using the project references to build one or more projects at the same time. Looks to me that the documentation is not up to date.

Also, it's important to note that in version 10.1, we'll be removing solutions style tsconfig see: #18478

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants