Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loaders for fonts #1765

Closed
wants to merge 10 commits into from

Conversation

stefannegele
Copy link
Contributor

Add loaders for several font types. Don´t know if SVG is really needed, hat no conflicts while using some in templates. All credits go to Adrian Hall (https://shellmonger.com/2016/01/22/working-with-fonts-with-webpack/).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

@filipesilva
Copy link
Contributor

@TheLarkInn can you review?

@TheLarkInn
Copy link
Member

This doesn't look up to date with master can you double check @LasTanzen

@stefannegele
Copy link
Contributor Author

Thanks for checking @TheLarkInn . Seems that 3b226be already added this. I checked the master branch in IE9 (Windows7), IE11 (Windows8), Edge (Windows10), Chrome, Firefox, Safari (Mac) and had problems with SVG-fonts and Safari due to the mandatory id after the hash in the URL. I fixed this and updated the PR after checking in all browsers again.

@filipesilva
Copy link
Contributor

@LasTanzen sorry it took so long to get to this PR. Thanks for the research, it looks good and ready to merge pending a rebase. Can you solve the conflict? I think we added a new font and that's all.

@stefannegele
Copy link
Contributor Author

Hi @filipesilva, I merged from master and did some browser testing. Cheers

@@ -0,0 +1,127 @@
import * as path from 'path';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems a remnant of a rebase, can you remove it? It's making the CI break.

@stefannegele
Copy link
Contributor Author

Argh, haven´t realized you meant the whole file. Removed it, sorry for the inconveniences. Hope it works now :)
.

@filipesilva
Copy link
Contributor

Thanks, we'll merge it soon!

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants