fix(@schematics/angular): regression tsconfig.json #16708

[dmorosinotto]

fix(@schematics/angular): regression tsconfig.json …
Unverified
0e318ae
Regression in tsconfig.json set "outDir": "./dist/out-tsc" for problems in VSCode TS(2307) when building library referred in tsconfig "paths"

Closes: #16708

[alan-agius4]

Thanks for this.

@clydin and myself looked at this and it seems that TS file watcher is not handling deletion well when excludes are involved.

While checking this I also saw some change in behaviour which involved path mappings which seems that auto imports were no longer being suggested.

Would you also mind to fix the following

angular-cli/packages/schematics/angular/library/index.ts

Line 70 in 49de0a6

tsconfig.compilerOptions.paths[packageName].push(distRoot);

so that itgenerates the below paths;

    "paths": {
      "foo": [
        "dist/foo/foo",
        "dist/foo"
      ]
    }

instead of:

    "paths": {
      "foo": [
        "dist/foo"
      ]
    }

The first path will be used by TSC, while the second will be used by Webpack.

[dmorosinotto]

Would you also mind to fix the following

@alan-agius4 Ok I'll update the code to add the second ref in the paths.
Do you think that it'll be acceptable to pass another param (the folderName) to the updateTSConfig function to do this?

[alan-agius4]

@dmorosinotto, no need as the packageName is the folder name.

[dmorosinotto]

@dmorosinotto, no need as the packageName is the folder name.

Well not exactly because if you pass a scoped name (like @myScope/myLib) due to strings.dasharize + scopeName handling if you use the packageName to write something like
tsconfig.compilerOptions.paths[packageName].push(distRoot + '/' + packageName);

You'll have this output :

"paths": {
      "@my-scope/my-lib": [
        "dist/my-scope/my-lib",
        "dist/my-scope/my-lib/@my-scope/my-lib"
      ]
 } 

You can try to test it in this blitz

that I suspect to be not exactly what you want, I think that this may be the correct one:

"paths": {
      "@my-scope/my-lib": [
        "dist/my-scope/my-lib",
        "dist/my-scope/my-lib/my-scope-my-lib"  //<-- note here NO @ and replace '/' with '-'
      ]
} 

JFYI I tryed to create a library with ng generate library @myScope/myLib and then compile it with ng build @myScoped/myLib with the current latest CLI 9.0.0.rc-9 and this is the output in /dist I don't know exactly which path Webpack will need?

@alan-agius4 Can you clarify me the real expected behavior? so I'll code the need changes, thanks!

[alan-agius4]

You are right the paths should be without @ and - and any other special symbol.

Also the order of the below is important, as changing the order will result in a different behaviour.

paths": {
      "@my-scope/my-lib": [
        "dist/my-scope/my-lib/my-scope-my-lib", -> used by the IDE to suggest correct imports.
        "dist/my-scope/my-lib" -> used by the apps Webpack as otherwise the compilation will not succede because the above points to a dts file
      ]
} 

[dmorosinotto]

Sorry @alan-agius4 I've done the code change directly online in GitHub and I've made a lint error (for whitespace) just fixed, but the real problems are the tests broken, can you help me with it?

[alan-agius4]

I’ll try to take a look in the coming days.

…

On Mon, 20 Jan 2020 at 20:00, Daniele Morosinotto ***@***.***> wrote: Sorry @alan-agius4 <https://github.com/alan-agius4> I've done the code change directly online in GitHub and I've made a lint error (for whitespace) just fixed, but the real problems are the tests broken, can you help me with it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16709?email_source=notifications&email_token=AEF74WV6IR5PGYEOJ42PS2TQ6XYFHA5CNFSM4KI2M742YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJNRYEA#issuecomment-576396304>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEF74WSDLUHRFRZ6TOKHU6DQ6XYFHANCNFSM4KI2M74Q> .

[dmorosinotto]

@alan-agius4 no problem, I've done some further investigations looking and the Detail log and found the failing tests code.
I've changed it according to the new behaviour, hoping to have done it right, please check my changes , and let's me know!

[alan-agius4]

LGTM, thanks

Caretaker note: kindly squash the commits.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}