Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set fs building/polyfill empty for better package support #1599

Merged
merged 2 commits into from
Aug 8, 2016

Conversation

TheLarkInn
Copy link
Member

@TheLarkInn TheLarkInn commented Aug 8, 2016

Fixes #1583.

Certain packages have issues with the default webpack node build-ins. fs specifically. Setting this to empty fixes this problem.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no and removed cla: yes labels Aug 8, 2016
@TheLarkInn
Copy link
Member Author

@googlebot HEY! Yes I signed it!!!

@filipesilva
Copy link
Contributor

@googlebot these commits were authored by me and @TheLarkInn and we are ok with them being used in this PR.

@hansl hansl added cla: yes and removed cla: no labels Aug 8, 2016
@hansl hansl merged commit 560ae8f into angular:master Aug 8, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending webpack config
4 participants